Skip to content

Commit

Permalink
release: alter order of release operations so git tag has all files
Browse files Browse the repository at this point in the history
the npm publish process itself dirties the repo, so you need to npm publish
first then commit + tag + push on git then create the release
  • Loading branch information
mikehardy committed Sep 11, 2024
1 parent 4c9d558 commit 4dde08d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,12 @@ Maintainers with write access to the repo and the npm organization can publish n
1. Navigate to the React Native package: `cd packages/react-native`
1. Update release notes [here](https://github.com/invertase/notifee/blob/main/docs-react-native/react-native/docs/release-notes.md)
1. Bump version: `npm version {minor/patch} --legacy-peer-deps`
1. Commit those changes
1. Publish to npm: `npm publish` (this generates a new core AAR)
1. Commit those changes (after npm publish so new AAR files are committed)
1. Tag the repo (current format is `@notifee/[email protected]`)
1. Push the release notes / version / tag to the repo: `git push --tags`
1. Create a release on the repo:
```
export TAGNAME=`git tag --list|sort -r|head -1`
gh release create ${TAGNAME} --title "${TAGNAME}" --notes "[Release Notes](https://github.com/invertase/notifee/blob/main/docs-react-native/react-native/docs/release-notes.md)"
```
1. Publish to npm: `npm publish`

0 comments on commit 4dde08d

Please sign in to comment.