Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

affiliations: update value property to use id #269

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

0einstein0
Copy link
Member

❤️ Thank you for your contribution!

Description

Partially Closes: #268

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@@ -90,7 +90,7 @@ export const AffiliationsSuggestions = (creatibutors, isOrganization) => {

return {
text: creatibutor.name,
value: creatibutor.name,
value: creatibutor.id || creatibutor.name,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was changed back and forth several time, could you explain why is it needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value prop was being used to set the selected value in the search input box, when for instance RWTH Aachen University was selected which was coming from two diff sources i.e. ror and edmo but had the same name in both, it selected both of them even if you click on one of them and the two entries would be selected in the input box as it was based on name which is not unique.

392781761-09d5e897-1efa-47a8-882b-de4bdee47687
392781760-93f9efa6-d167-4724-a3fd-09aa40f3fcd3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: affiliations with the same name get multi-selected
2 participants