routes: Render browser tab title based on literature title #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpsherva
reviewed
Mar 8, 2024
| @@ -104,8 +111,10 @@ DocumentDetails.propTypes = { | |||
| documentPid: PropTypes.string, | |||
| }), | |||
| }).isRequired, | |||
| renderTabTitle: PropTypes.func, | |||
There was a problem hiding this comment.
if you add as required prop, we can avoid the if statement on each function call
ntarocco
force-pushed
the
master
branch
2 times, most recently
from
9426505 to
014ef04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❤️ Thank you for your contribution!
Description
Note: This is just an example PR on how the tab title rendering would look code wise, I have listed down some pain points in this approach would be very happy to get some feedback -
renderTabTitlepropCERN Library Catalogueagain as it should, fix is it set thedocument.title =to the components.