Minor bugfixes #180
Merged
Minor bugfixes #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
FlorianCassayre
commented
Sep 1, 2020
•
FlorianCassayre
commented
- addresses UI testing: issues #172
- DocumentAuthors component raising exception
- "checkout" button in loan requests not disabled during loading
- LiteratureCover flickering on page change (closes literature: cover image displays previous state #135)
- hide navigation buttons in patron loans on empty result set
- BorrowingRequestPatronLoan state not reset
- ESSelectorLoanRequest request button not disabled
- SearchSortOrderElementMobile uninitialized attribute
- ExportSearchResults not starting from the first page
- ScrollingMenu first element not selected due to typo
- HitsSearch & ESSelector toggleable initial focus, disabled by default
- LoanMetadata invalid dates displayed
FlorianCassayre
force-pushed
the
minor-fixes-4
branch
5 times, most recently
from
7ba52e7 to
9f0ae99
Compare
* DocumentAuthors component raising exception * "checkout" button in loan requests not disabled during loading * LiteratureCover flickering on page change * hide navigation buttons in patron loans on empty result set * BorrowingRequestPatronLoan state not reset * ESSelectorLoanRequest request button not disabled * SearchSortOrderElementMobile uninitialized attribute * ExportSearchResults not starting from the first page * ScrollingMenu first element not selected due to typo * HitsSearch & ESSelector toggleable initial focus, disabled by default * LoanMetadata invalid dates displayed
FlorianCassayre
force-pushed
the
minor-fixes-4
branch
from
9f0ae99 to
a139432
Compare
kpsherva
approved these changes
Sep 9, 2020
| @@ -105,6 +105,7 @@ class ExportSearchResultsWithState extends Component { | |||
|
|
|||
| // append the `format` param | |||
| const params = Qs.parse(queryString); | |||
| params['page'] = 1; // Start from the first page | |||
There was a problem hiding this comment.
how will it behave with other pages?
There was a problem hiding this comment.
New behavior: the button has the same effect, regardless the currently selected page. Namely it exports the results of the search without taking pagination into account. I assumed this was the intended semantic of that button since it's said to return the "first 10,000 records".
Did I miss something?
There was a problem hiding this comment.
I need to investigate this further to make sure, I will merge this and start a ticket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.