Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dictutils: add filter_dict_keys #321

Merged
merged 2 commits into from
Feb 19, 2024
Merged

dictutils: add filter_dict_keys #321

merged 2 commits into from
Feb 19, 2024

Conversation

yashlamba
Copy link
Member

slint
slint reviewed Feb 19, 2024
View reviewed changes
Copy link
Member

@slint slint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you add a very basic "smoke test"? Since it's a utility there's no fixtures needed, so try to add a couple of common dictionary cases (especially with nested values).

@slint slint merged commit f7e18cf into inveniosoftware:master Feb 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slint slint slint left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

move function to dictutils
2 participants
@yashlamba @slint