Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: replace nested_session with commit #320

Closed
wants to merge 1 commit into from
Closed

api: replace nested_session with commit #320

wants to merge 1 commit into from

Conversation

jrcastro2
Copy link
Contributor

kpsherva
kpsherva reviewed Nov 10, 2023
View reviewed changes
invenio_records/api.py
db.session.merge(self.model)
# Check this
db.session.merge(self.model)
db.session.commit()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is potentially harming operation, the method was probably not meant to be responsible for committing the whole session here

@zzacharo
Copy link
Member

I am closing this, as the added db.session.commit() affects the saving of drafts i.e not allowing partial valid records.

@zzacharo zzacharo closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpsherva kpsherva kpsherva left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrcastro2 @zzacharo @kpsherva