Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub release fix #1540

Merged
merged 2 commits into from
Oct 14, 2023
Merged

Conversation

kpsherva
Copy link
Contributor

@kpsherva kpsherva commented Oct 14, 2023

alejandromumo
alejandromumo previously approved these changes Oct 14, 2023
@alejandromumo
Copy link
Member

alejandromumo commented Oct 14, 2023

The user identity is computed from the owner of the repository, I am not sure whether this could have an impact on shared repos.

How is this relevant for the linked issue on sentry?

@alejandromumo alejandromumo self-requested a review October 14, 2023 11:38
@alejandromumo alejandromumo dismissed their stale review October 14, 2023 11:38

re-checking edge case

@kpsherva
Copy link
Contributor Author

The user identity is computed from the owner of the repository, I am not sure whether this could have an impact on shared repos.

How is this relevant for the linked issue on sentry?

tries to read a deleted record and fails with 410
good point however, I will fix it another way

@alejandromumo
Copy link
Member

The user identity is computed from the owner of the repository, I am not sure whether this could have an impact on shared repos.
How is this relevant for the linked issue on sentry?

tries to read a deleted record and fails with 410 good point however, I will fix it another way

I think this is fine. If the record is deleted, that Openaire index task should fail and set a key in the cache.
Afterwards, we have another task that reads from that cache and - if the record is deleted - sends a request to OpenAIRE.

@kpsherva kpsherva merged commit 19cb2d0 into inveniosoftware:master Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants