Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: removed organization from affiliation #1534

Merged

Conversation

0einstein0
Copy link
Member

❤️ Thank you for your contribution!

Description

Removed the organization from being added to it's own affiliation

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

name: selectedSuggestion.name,
},
],
organizationAffiliations: [],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be:

Suggested change
organizationAffiliations: [],
organizationAffiliations: selectedSuggestion.affiliations,

if the organisation has any affiliations ? I am not sure if that ever happens

Copy link
Member Author

@0einstein0 0einstein0 Oct 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no it doesn't have any as of yet, that attr doesn't exist for it.

@kpsherva kpsherva merged commit b812c0d into inveniosoftware:master Oct 12, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants