Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: serialization of from parameter #244

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

floriangantner
Copy link

@floriangantner floriangantner commented Nov 18, 2024

see #243

Description

Please describe briefly your pull request.

  • fixes serialization of from parameter in marshmallow. Before the attribute in the response was returned as "from_"

  • usage of load_from and dump_tohas been replaced by data_key in marshmallow 3.0.0.b8

  • additional usage of parameter attribute for the special case for variable from See marshmallow docs , Chapter Field.attribute and it's Note: This should only be used for very specific use cases such as outputting multiple fields for a single attribute, or using keys/attributes that are invalid variable names, unsuitable for field names. In most cases, you should use data_key instead.

  • add new test case for response when from date is after until date

  • enhance existing test cases to check for the from and until attribute in the response.

  • improves overall test coverage by reducing missing statements from 60 to 59

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

fixes serialization of from parameter
- new test case to check from date after until date
- enhance test cases for from and until attribute in responses
@floriangantner floriangantner marked this pull request as ready for review November 19, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant