fix: serialization of from parameter #244
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #243
Description
fixes serialization of from parameter in marshmallow. Before the attribute in the response was returned as "from_"
usage of
load_from
anddump_to
has been replaced bydata_key
in marshmallow 3.0.0.b8additional usage of parameter
attribute
for the special case for variablefrom
See marshmallow docs , Chapter Field.attribute and it'sNote: This should only be used for very specific use cases such as outputting multiple fields for a single attribute, or using keys/attributes that are invalid variable names, unsuitable for field names. In most cases, you should use data_key instead.
add new test case for response when from date is after until date
enhance existing test cases to check for the from and until attribute in the response.
improves overall test coverage by reducing missing statements from 60 to 59
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: