-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config: Granular env-based Solution for Connection Strings #57
Open
Samk13
wants to merge
2
commits into
inveniosoftware:master
Choose a base branch
from
Samk13:calc-connection-strings-util
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Config: Granular env-based Solution for Connection Strings #57
Samk13
wants to merge
2
commits into
inveniosoftware:master
from
Samk13:calc-connection-strings-util
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
10 tasks
Samk13
force-pushed
the
calc-connection-strings-util
branch
from
November 26, 2024 14:58
bf02100
to
6ceb654
Compare
egabancho
reviewed
Nov 27, 2024
Samk13
force-pushed
the
calc-connection-strings-util
branch
2 times, most recently
from
November 27, 2024 16:40
8f4b0e6
to
2e1e160
Compare
Samk13
changed the title
Config: Granular ENV-based Solution for Connection Strings
Config: Granular env-based Solution for Connection Strings
Nov 28, 2024
Samk13
force-pushed
the
calc-connection-strings-util
branch
6 times, most recently
from
November 28, 2024 13:39
5eeef92
to
e52709c
Compare
Samk13
added a commit
to Samk13/invenio-dev-latest
that referenced
this pull request
Nov 29, 2024
* testing with inveniosoftware/invenio-config#57
Samk13
force-pushed
the
calc-connection-strings-util
branch
from
December 2, 2024 17:52
e52709c
to
c8d1038
Compare
Samk13
added a commit
to Samk13/invenio-dev-latest
that referenced
this pull request
Dec 2, 2024
* testing with inveniosoftware/invenio-config#57
Samk13
force-pushed
the
calc-connection-strings-util
branch
5 times, most recently
from
December 3, 2024 14:16
b9c6913
to
8859a27
Compare
egabancho
approved these changes
Jan 13, 2025
utnapischtim
approved these changes
Jan 13, 2025
Add logic to build connection urls from env vars if available needed for helm charts security best practices. includes: * Build db uri * Build redis url * Build mq url Partially closes: inveniosoftware/helm-invenio#112
Samk13
force-pushed
the
calc-connection-strings-util
branch
from
January 15, 2025 12:45
49faf05
to
f03c861
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❤️ Thank you for your contribution!
Description
Add logic to build connection URLs from env vars if available
needed for helm charts security best practices.
This PR includes:
Partially closes: inveniosoftware/helm-invenio#112
Depends on: inveniosoftware/invenio-app-rdm#2918
Note
I created a test version encapsulated in a cached class. Let me know if you prefer this over simple functions, and I’ll update accordingly see link
Findings
For the database URI, ensure that
SQLALCHEMY_DATABASE_URI=""
is set to an empty string to allow the granular variables to take effect.For the broker, I opted for the naming convention
INVENIO_RABBITMQ_*
instead ofINVENIO_BROKER_*
, as the latter conflicts with RabbitMQ's default naming variables. For more details, refer to the documentation here.For reviewers:
I set up a testing instance to test these changes, with the
.env
file anddocker-services
modified, see: https://github.com/Samk13/invenio-dev-latest/tree/granular-env-vars-changesinvenio-app-rdm
to set these variables.Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: