Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Update RichEditor to use inputValue #1185

Merged

Conversation

Samk13
Copy link
Member

@Samk13 Samk13 commented Aug 2, 2024

❤️ Thank you for your contribution!

Description

This will fix the editor's loss of content after losing focus in communities invite modal
Closes inveniosoftware/invenio-app-rdm#2771
Related to inveniosoftware/react-invenio-forms#249

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

Sorry, something went wrong.

@Samk13 Samk13 requested a review from max-moser August 2, 2024 13:06
@Samk13 Samk13 force-pushed the fix-richEditor-invitation-modal branch 5 times, most recently from 2536b44 to f8c5f91 Compare August 3, 2024 16:18
Copy link
Contributor

@max-moser max-moser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basically the same change as in inveniosoftware/react-invenio-forms#249, which fixed an issue where the editor lost its content when it lost focus

Copy link
Contributor

@max-moser max-moser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with some quick testing (of the community member invitation modal) on a local v13 i couldn't find the issue of the editor losing content when losing focus.
however, i could find this issue in a v12 setup and this PR (backported) fixed that.
on v13, i could not detect any adverse effects with this PR.

@max-moser max-moser force-pushed the fix-richEditor-invitation-modal branch from acf2449 to c190662 Compare August 5, 2024 10:06
@Samk13
Copy link
Member Author

Samk13 commented Aug 5, 2024

with some quick testing (of the community member invitation modal) on a local v13 i couldn't find the issue of the editor losing content when losing focus. however, i could find this issue in a v12 setup and this PR (backported) fixed that. on v13, I could not detect any adverse effects with this PR.

From my testing, this issue appears to be flaky, it sometimes works and sometimes doesn't, which was confusing. Therefore, I've decided to keep this change for now, as it guarantees the functionality.
Unless a cleaner solution is found, we'll proceed with this for now.
For the failing CI I added this one: #1186 so no need to worry about it.

@max-moser
Copy link
Contributor

alright, thanks for the extra infos!
as an immediate fix, i just replaced docker-compose --version with docker compose version.
when the CI actions get reworked, this will be replaced anyway :)

@max-moser max-moser merged commit 5d329a0 into inveniosoftware:master Aug 5, 2024
4 checks passed
@Samk13 Samk13 deleted the fix-richEditor-invitation-modal branch August 8, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deposit form: description field loses content after losing focus
2 participants