pids: pass optional DOI transitions in the upload form #2958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzacharo
force-pushed
the
doi-completion
branch
from
90e989b to
9be19a6
Compare
zzacharo
force-pushed
the
doi-completion
branch
from
291a732 to
b3f127b
Compare
jrcastro2
reviewed
Jan 20, 2025
|
|
||
| @wraps(f) | ||
| def view(*args, **kwargs): | ||
| response = make_response(f(*args, **kwargs)) |
There was a problem hiding this comment.
Minor: I would check if the func already returns a Response, in that case we don't need the make_response, so it can be used by all funcs.
Suggested change
| response = make_response(f(*args, **kwargs)) | |
| result = f(*args, **kwargs) | |
| if isinstance(result, Response): | |
| response = result | |
| else: | |
| response = make_response(result)``` |
zzacharo
force-pushed
the
doi-completion
branch
from
b3f127b to
ac4c2b3
Compare
Co-authored-by: jrcastro2 <[email protected]> closes CERNDocumentServer/cds-rdm#302
zzacharo
force-pushed
the
doi-completion
branch
from
ac4c2b3 to
b32d974
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes CERNDocumentServer/cds-rdm#303, CERNDocumentServer/cds-rdm#302
requires inveniosoftware/invenio-rdm-records#1927