-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add email and sha1 identifiers #96
base: master
Are you sure you want to change the base?
Conversation
I note that a new version of black (>24) has caused tests to fail on an existing line. Happy to fix the line length - or should we pin black? |
i think this PR changed the behavior with long lines in dict's. we had the problem of different rules in newer black versions already and as i know already used the new style. |
This is an issue that's going to affect all packages... I'll wait and see what happens elsewhere :) |
i also think that the easiest would be to just fix it and adopt the new style. |
Done, does this otherwise seem sensible? |
yes it does, although i am not sure where you will use it. |
The (in my view overlooked) use case is any Invenio instance where you want to associate one or more email addresses with a creatibutor (in addition / as an alternative to ORCID, GND etc). We have instances doing this, and others have asked the question on Discord. The email_sha1 is specifically for planned work on WADM based annotation. The DataCite schema accepts any scheme + URI as a nameIdentifier, so these additions are compatible with DataCite. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly the hexadecimal thing to double-check, but otherwise LGTM.
Co-authored-by: Guillaume Viger <[email protected]>
❤️ Thank you for your contribution!
Description
This adds support for email and sha1 identifiers.
I was interested to learn that WADM (and possibly other W3C standards) allow the sha1 of an email address as a personal identifier for a creator to allow identification without revealing email addresses.
https://www.w3.org/TR/annotation-model/#agents
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Third-party code
If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: