Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Risk Acceptances workflow testing #777

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

Alexdev8
Copy link
Contributor

This test checks that risk acceptances can be accepted, refused and revoked and that a non approver user cannot be selected as an approver for a risk acceptance.

Duration: approx. 28s

This test could maybe also include the check that a non approver user cannot effectively approve a risk acceptance he is not assigned to.
However, this addition would significantly extend the duration of the test and I didn't think it would be worth

@Alexdev8 Alexdev8 marked this pull request as ready for review August 30, 2024 10:47
@Alexdev8
Copy link
Contributor Author

The logedpage parameter removed in the commit 6d418a3 is not in fact unused. It is a fixture called by Playwright at the start of the test and removing it inevitably cause it to fail.

I don't know how to pass the CodeFactor check with this parameter. Maybe just by calling logedPage in the test for no other reason than the GitHub check. Or we can just ignore the CodeFactor check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants