Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ca 545 add ref id to all editable objects #1044

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Ca 545 add ref id to all editable objects #1044

wants to merge 27 commits into from

Conversation

melinoix
Copy link
Contributor

Added a reference ID to all editable projects : risk-assessments, domains, projects, compliance-assessments, applied-controls.

nas-tabchiche
nas-tabchiche requested changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@nas-tabchiche nas-tabchiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In almost all cases, a single PR should not have more than one single migration per app. This is mergeable once migrations are squashed and tests pass.

@melinoix
Copy link
Contributor Author

-Have to modify tests/Api tests

  • projects tab have internal reference to replace & adjust the tests too
  • domain is quite different so adapt the migration to it ( iam file instead of core file )

@Mohamed-Hacene Mohamed-Hacene marked this pull request as draft November 18, 2024 11:06
melinoix and others added 17 commits November 18, 2024 16:21
@melinoix
corrected migrations, added folder, removed internal ref
e5b70e9
@melinoix
corrected project api tests
42c0f4d
@melinoix
Merge branch 'main' into CA-545-add-ref-id-to-all-editable-objects
2e9be80
@melinoix
merged with main
11df68d
@melinoix
corrected migrations
d8c6858
@melinoix
corrected migrations
2740b09
@melinoix
correct migrations
e07af5f
@melinoix
correct migrations
13af317
@melinoix
correct format
460c528
@melinoix
without folder
2165dab
@melinoix
Merge branch 'main' into CA-545-add-ref-id-to-all-editable-objects
26bb9fd
@melinoix
correct migration conflicts
6e3629f
@nas-tabchiche
Merge branch 'main' into CA-545-add-ref-id-to-all-editable-objects
2f2ff47
@nas-tabchiche
Change project internal reference to ref id in tests and interfaces
2fdab93
@nas-tabchiche
Remove internal_reference from ProjectViewSet.search_fields
de46e46
@nas-tabchiche
Change project internal reference to ref id in data model docs
f28a936
@nas-tabchiche
Fix ref id field title functional test
2e9da47
@nas-tabchiche nas-tabchiche marked this pull request as ready for review November 24, 2024 10:16
eric-intuitem
eric-intuitem requested changes Nov 24, 2024
View reviewed changes
Copy link
Collaborator

@eric-intuitem eric-intuitem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref_id missing in detail view for applied controls (and possibly others).
Sometime we have "reference", sometime "reference id", we should harmonise to "reference id".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-intuitem eric-intuitem eric-intuitem requested changes

@ab-smith ab-smith Awaiting requested review from ab-smith

@nas-tabchiche nas-tabchiche Awaiting requested review from nas-tabchiche

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@melinoix @nas-tabchiche @eric-intuitem