forked from leinardi/mypy-pycharm
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP code #1
Open
intgr
wants to merge
13
commits into
main
Choose a base branch
from
wip
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intgr
force-pushed
the
wip
branch
3 times, most recently
from
November 26, 2021 13:30
0b4e0d7
to
42fac10
Compare
Previously error message was truncated where a colon appeared. Before: ``` Dict entry 0 has incompatible type "int" ``` After ``` Dict entry 0 has incompatible type "int": "str"; expected "int": "int" [dict-item] ```
…colon Fix display of error messages with colon
'gradlew check' was failing for me for half a dozen different reasons. To be completely frank, I have no idea what I'm doing. I'm not familiar with the tools used in the Java world. I just kept applying solutions from StackOverflow until it seemed to work.
Make Gradle check work
Using the `ExternalAnnotator` API (instead of `LocalInspectionTool`) behaves a lot better with slow scanners like mypy and fixes reported performance problems with the plugin (fixes leinardi#43). Following multiple successive changes to a file, `LocalInspectionTool` can invoke the checker for each modification from multiple threads in parallel, which can bog down the system. `ExternalAnnotator` cancels the previous running check (if any) before running the next one. Modeled after `com.jetbrains.python.validation.Pep8ExternalAnnotator`
According to IntelliJ Plugin Verifier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.