Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP code #1

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

WIP code #1

wants to merge 13 commits into from

Conversation

intgr
Copy link
Owner

@intgr intgr commented Nov 25, 2021

No description provided.

@intgr intgr force-pushed the wip branch 3 times, most recently from 0b4e0d7 to 42fac10 Compare November 26, 2021 13:30
intgr and others added 4 commits November 26, 2021 17:58
Previously error message was truncated where a colon appeared.

Before:
```
Dict entry 0 has incompatible type "int"
```
After
```
Dict entry 0 has incompatible type "int": "str"; expected "int": "int"  [dict-item]
```
…colon

Fix display of error messages with colon
'gradlew check' was failing for me for half a dozen different reasons.

To be completely frank, I have no idea what I'm doing. I'm not familiar
with the tools used in the Java world. I just kept applying solutions
from StackOverflow until it seemed to work.
leinardi and others added 8 commits November 29, 2021 18:38
Using the `ExternalAnnotator` API (instead of `LocalInspectionTool`) behaves a lot better with slow scanners like mypy and fixes reported performance problems with the plugin (fixes leinardi#43).

Following multiple successive changes to a file, `LocalInspectionTool` can invoke the checker for each modification from multiple threads in parallel, which can bog down the system. `ExternalAnnotator` cancels the previous running check (if any) before running the next one.

Modeled after `com.jetbrains.python.validation.Pep8ExternalAnnotator`
According to IntelliJ Plugin Verifier.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants