[uss_qualifier] scd subscrptions: stop considering 404 a success, add was_not_found #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminPelletier
approved these changes
Sep 12, 2024
punamverma
pushed a commit
to nasa/monitoring
that referenced
this pull request
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
class FetchedSubscription(fetch.Query)currently considers receiving a 404 from the DSS a success (ie, thesuccessproperty will return True).This is not strictly correct and can lead to confusion: a 404 will now cause
successto be false. Callers that need to differentiate between a failure and a 404 may usewas_not_foundwhich will only be true if the returned code was 404.Split out of #720