[uss_qualifier] submit_flight_intent test step raises if flight intent ends in the past #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shastick
force-pushed
the
648-fix-fi-length
branch
3 times, most recently
from
7899eaa
to
f8c460d
Compare
|
Note: taken back to draft until |
…t ends in the past
Shastick
force-pushed
the
648-fix-fi-length
branch
from
f8c460d
to
bd7e194
Compare
Shastick
commented
Apr 22, 2024
monitoring/uss_qualifier/scenarios/flight_planning/test_steps.py
Outdated
Show resolved
Hide resolved
|
I added some suggestions here |
…#16) These suggestions for [650 on the interuss repo](interuss#650) primarily: * Adjust the datetime comparison approach -- we don't want to mess with time zones, or generally Python's suboptimal time treatment; we can leave that to the `arrow` module we already import and use for many other similar things * Expand and make public the function to compute an end time of volume or volumes * Change StartOfTestRun to StartOfScenario in most test data -- I think this is the most likely thing to fix most of the problems as it decouples timing for a scenario from the rest of the scenarios in a test suite/run
|
Thanks for the suggestions, I took them over. |
BenjaminPelletier
approved these changes
Apr 23, 2024
github-actions bot
added a commit
that referenced
this pull request
Apr 23, 2024
…t ends in the past (#650) * [uss_qualifier] submit_flight_intent test step raises if flight intent ends in the past * Update datetime approach and change StartOfTestRun to StartOfScenario (#16) These suggestions for [650 on the interuss repo](#650) primarily: * Adjust the datetime comparison approach -- we don't want to mess with time zones, or generally Python's suboptimal time treatment; we can leave that to the `arrow` module we already import and use for many other similar things * Expand and make public the function to compute an end time of volume or volumes * Change StartOfTestRun to StartOfScenario in most test data -- I think this is the most likely thing to fix most of the problems as it decouples timing for a scenario from the rest of the scenarios in a test suite/run --------- Co-authored-by: Benjamin Pelletier <[email protected]> 5ab499f
github-actions bot
added a commit
to Orbitalize/monitoring
that referenced
this pull request
Apr 23, 2024
…t ends in the past (interuss#650) * [uss_qualifier] submit_flight_intent test step raises if flight intent ends in the past * Update datetime approach and change StartOfTestRun to StartOfScenario (#16) These suggestions for [650 on the interuss repo](interuss#650) primarily: * Adjust the datetime comparison approach -- we don't want to mess with time zones, or generally Python's suboptimal time treatment; we can leave that to the `arrow` module we already import and use for many other similar things * Expand and make public the function to compute an end time of volume or volumes * Change StartOfTestRun to StartOfScenario in most test data -- I think this is the most likely thing to fix most of the problems as it decouples timing for a scenario from the rest of the scenarios in a test suite/run --------- Co-authored-by: Benjamin Pelletier <[email protected]> 5ab499f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check and raise if the flight intent that will be injected ends in the past, while also double the default duration for some configured
flight_intents(see below for details)This fixes #648
Open questions:
ValueErrorthe correct approach?Testing
Tested updating the default
durationin monitoring/uss_qualifier/test_data/flight_intents/standard/invalid_flight_intents.yaml to 5 seconds: this causes the error to be raised locally when running the f3548 self-contained scenario