[scd] oir upsert: factor implicit subscription creation #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shastick
force-pushed
the
oir-upsert-refactor-2-implicit-sub-creation
branch
3 times, most recently
from
8196f7d
to
1e5ac33
Compare
mickmis
reviewed
Sep 2, 2024
Shastick
force-pushed
the
oir-upsert-refactor-2-implicit-sub-creation
branch
from
ce42c49
to
144829f
Compare
Also moves the implicit subscription URL check to parameter validation
Shastick
force-pushed
the
oir-upsert-refactor-2-implicit-sub-creation
branch
from
144829f
to
a51d9f6
Compare
mickmis
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also moves the implicit subscription URL check to parameter validation
another step for #1088