[terraform-aws-kubernetes] Reduce the size of the default node disks #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminPelletier
approved these changes
Apr 11, 2024
|
Until we have automatic versioning and migration, we should make sure to flag any breaking changes like this in the notes for the next release. |
I created a draft release to capture this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The size of disks used by the EC2 node is not actually used by the workloads deployed in Kubernetes. Volumes created by Kubernetes are attached to that node and therefore provisioning 100G for the host do not make sense.
This PR reduces it at 10G.
Note that this change may require a recreation of the nodes, therefore, it is probably soon the right time to start versioning the terraform, tanka and helm manifests in a package manager, cf [C.4] of #874.