-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save subject page body to Tag.body
when tags are created
#9843
base: master
Are you sure you want to change the base?
Conversation
$if has_tag: | ||
<h3 itemprop="description"> | ||
$page.tag['description'] | ||
</h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we do want this somewhere on the page, just not in a heading element (and maybe somewhere else on the page).
Maybe displaying this before tag.body
in /type/tag/view.html
is the right spot? This would ensure that:
- The description is always present in the tag's view
- The description only appears on the page once when
tag.body
is a rendered subject page
670055b
to
80d1541
Compare
Labeled
Needs: Submitter Input
The last item will likely require that the conditional logic that was added to the "Edit" button is removed (i.e. the button's |
`wmd` is throwing an error on `/tag/add` pages, and will not render two preview panes. Since a tag's description is not rendered anywhere, there is no need to include the markdown editor for that input.
Clicking the "Promote to Tag" button now creates a new Tag and redirects to the new Tag's "view" page.
for more information, see https://pre-commit.ci
b87b547
to
cc16c28
Compare
Addresses: #9685
Makes the following changes to the subject page editing flow:
fkey
field when a tag is created from a/subjects/*
pagebody
textarea
to the tag form inputs/tags/*
page when they navigate to a subject page that is linked to aTag
Limitations
Technical
fkey
is meant to be immutable, and is displayed in a read-only input.Testing
Try the following:
Tag
. Ensure that there is a "Create Tag" button in the upper-right corner of the content body./tags/*
page, and that the subject page's body is being rendered.Tag
page.Screenshot
The "Create Tag" button
Stakeholders