dns/ddclient/dyndns2: fix the ovh-dyndns as reported in opnsense#3679

According to https://help.dyn.com/remote-access-api/perform-update/ system parameter should be safely ignored by compliant providers
interj · Dec 6, 2023 · 5858458 · 5858458
1 parent 289d7f2
commit 5858458
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/dns/ddclient/src/opnsense/scripts/ddclient/lib/account/dyndns2.py b/dns/ddclient/src/opnsense/scripts/ddclient/lib/account/dyndns2.py
@@ -89,16 +89,14 @@ def execute(self):
                     'params': {
                         'hostname': self.settings.get('hostnames'),
                         'myip': self.current_address,
-                        'wildcard': 'ON' if self.settings.get('wildcard', False) else 'NOCHG'
+                        'wildcard': 'ON' if self.settings.get('wildcard', False) else 'NOCHG',
+                        'system': 'dyndns'
                     },
                     'auth': HTTPBasicAuth(self.settings.get('username'), self.settings.get('password')),
                     'headers': {
                         'User-Agent': 'OPNsense-dyndns'
                     }
                 }
-                if self.settings.get('service') == 'ovh':
-                    req_opts['params']['system'] = 'dyndns'
-
                 req = requests.get(**req_opts)
 
             if 200 <= req.status_code < 300: