Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing for dynamic object_id for delete call #176

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lukas-gitl
Copy link

This is according to how intercoms official api supports this

#158

Untested

This is according to how intercoms official api supports this

intercom#158
@coveralls
Copy link

coveralls commented Oct 25, 2017

Coverage Status

Coverage increased (+0.004%) to 95.858% when pulling 2f3acb0 on lukas-gitl:patch-1 into 60b1413 on jkeyes:master.

@coveralls
Copy link

coveralls commented Oct 26, 2017

Coverage Status

Coverage increased (+0.004%) to 95.858% when pulling 62e5f02 on lukas-gitl:patch-1 into 60b1413 on jkeyes:master.

@lukas-gitl
Copy link
Author

Once concern with this pr is that obj is no longer returned in all cases. I'm curious why an object should be returned from a delete call at all though?

@aleonsan
Copy link

+1 to delete Leads

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants