Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change unsubscribedFromEmails type to boolean for userAttributesForDictionary ios #206

Merged

Conversation

FabianTrain
Copy link
Contributor

I was unable to change the intercom user attirbute unsubscribedFromEmails on iOS. It seems like there is an issue with using a string as a type. I changed the unsubscribedFromEmails type to BOOL.

This issue seems to be from the old react-native-intercom package, where it was fixed.

=> tinycreative/react-native-intercom@d777d50

@Br1an-Boyle
Copy link
Contributor

Thanks @FabianTrain
You'll need to update the PR with the latest from main before you merge.

@FabianTrain
Copy link
Contributor Author

@Br1an-Boyle Thank you for the review. I updated from main.

@Br1an-Boyle Br1an-Boyle merged commit 964b577 into intercom:main Jun 19, 2024
6 checks passed
@FabianTrain FabianTrain deleted the unsubscribeFromEmails-ios-issue branch June 20, 2024 11:43
@tamlyn
Copy link

tamlyn commented Aug 8, 2024

Thanks @FabianTrain for finding and fixing this.

For anyone else coming here, this fixed a bug in the iOS part of the Intercom React Native SDK which caused both false and true values to be interpreted as true.

For us, this meant when someone opted in to email marketing, we sent unsubscribedFromEmails: false but this resulted in the contact in Intercom being tagged with unsubscribed_from_emails: true! It started when we upgraded from v6.1.0 to v6.7.0 in March.

Fortunately we were able to fix our Intercom records by exporting analytics data from Amplitude. But it's taken over a day to identify and correct the problem, and very likely cost us lost revenue from the many hundreds of users who haven't been receiving the emails they asked for. 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants