[ffmpeg-vaapi] add b_depth test options for h264 encode #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hangjie22Coder
force-pushed
the
b_depth
branch
3 times, most recently
from
6af14d0 to
934603b
Compare
Hangjie22Coder
changed the title
Hangjie22Coder
force-pushed
the
b_depth
branch
from
934603b to
7d4c01b
Compare
uartie
requested changes
Aug 26, 2024
There was a problem hiding this comment.
We can't just add a new parameter to an existing test. The test case name is derived from the test function signature and is tracked in history by that name. If you add a new parameter, then the test case names change and we lose history.
Also, every middleware test of the same name must use the same test function signature. That is, every test that uses this parameter generator must match their function signature that takes the parameters. Otherwise, they will be broken.
|
Maybe better to just create a new test function (e.g. |
Hangjie22Coder
force-pushed
the
b_depth
branch
from
7d4c01b to
12b453d
Compare
Hangjie22Coder
changed the title
Hangjie22Coder
force-pushed
the
b_depth
branch
2 times, most recently
from
ea16a4c to
57e3bda
Compare
uartie
requested changes
Aug 29, 2024
Hangjie22Coder
force-pushed
the
b_depth
branch
from
57e3bda to
51e854f
Compare
uartie
requested changes
Aug 30, 2024
|
Also, please fix conflicts |
Hangjie22Coder
force-pushed
the
b_depth
branch
from
51e854f to
95608f6
Compare
Signed-off-by: Wang Hangjie <[email protected]>
Hangjie22Coder
force-pushed
the
b_depth
branch
from
95608f6 to
2d2da41
Compare
fixed |
uartie
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.