Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jekyll build checks to match actual deployment, constrain version #79

Merged
merged 4 commits into from
Jan 6, 2025

Conversation

mkorbel1
Copy link
Contributor

@mkorbel1 mkorbel1 commented Jan 6, 2025

Description & Motivation

The action "Jekyll-Deploy-Test-Action" was not doing exactly the same thing as the actual deployment, and a recent new version of ruby (3.4) was apparently not sufficiently backwards compatible.

https://github.com/intel/rohd-website/actions/runs/12638241511/job/35214099116

/usr/local/lib/ruby/gems/3.4.0/gems/bundler-2.4.19/lib/bundler/runtime.rb:304:in 'Bundler::Runtime#check_for_activated_spec!': You have already activated json 2.9.1, but your Gemfile requires json 2.7.2. Since json is a default gem, you can either remove your dependency on it or try updating to a newer version of bundler that supports json as a default gem. (Gem::LoadError)

This PR ditches the action and instead uses the actual build step used in deployment to make sure it builds, and just skips the deploy step if it's only a PR.

It looks like we may soon need to update the minimum ruby version as well, but that's not included in this PR:

PSA: I18n will be dropping support for Ruby < 3.2 in the next major release (April 2025), due to Ruby's end of life for 3.1 and below (https://endoflife.date/ruby). Please upgrade to Ruby 3.2 or newer by April 2025 to continue using future versions of this gem.

Related Issue(s)

N/A

Testing

This PR should test it

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? Are any links changing? If yes, how so?

No

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

No

@mkorbel1 mkorbel1 merged commit de7a312 into intel:main Jan 6, 2025
3 checks passed
@mkorbel1 mkorbel1 deleted the jekyll_build_fix branch January 6, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant