Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integer divider #87

Merged
merged 10 commits into from
Sep 16, 2024
Merged

Integer divider #87

merged 10 commits into from
Sep 16, 2024

Conversation

kimmeljo
Copy link
Contributor

Description & Motivation

A parametrizable (operand + result width) integer divider. Can be used in computational units like an ALU.

Related Issue(s)

N/A

Testing

Added a new test suite for the divider in which both directed and pseudo random tests are executed (can fix the seed for reproducibility).

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

No - fully backwards compatible as it an addition to the repository.

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

Included in the doc subdirectory as a new subdocument.

Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice implementation!

lib/src/divider.dart Outdated Show resolved Hide resolved
doc/components/divider.md Outdated Show resolved Hide resolved
lib/src/divider.dart Outdated Show resolved Hide resolved
lib/src/divider.dart Outdated Show resolved Hide resolved
lib/src/divider.dart Outdated Show resolved Hide resolved
lib/src/divider.dart Outdated Show resolved Hide resolved
lib/src/divider.dart Outdated Show resolved Hide resolved
lib/src/divider.dart Outdated Show resolved Hide resolved
test/divider_test.dart Outdated Show resolved Hide resolved
test/divider_test.dart Outdated Show resolved Hide resolved
doc/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@desmonddak desmonddak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm excited to see another component builder factoring out components for ROHD-HCL!

lib/src/divider.dart Outdated Show resolved Hide resolved
lib/src/divider.dart Outdated Show resolved Hide resolved
lib/src/divider.dart Outdated Show resolved Hide resolved
lib/src/arithmetic/divider.dart Outdated Show resolved Hide resolved
lib/src/arithmetic/divider.dart Outdated Show resolved Hide resolved
Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice!

@mkorbel1 mkorbel1 merged commit 19eeb38 into intel:main Sep 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants