Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate parallel_prefix to new branch #77

Merged
merged 5 commits into from
Feb 6, 2024
Merged

migrate parallel_prefix to new branch #77

merged 5 commits into from
Feb 6, 2024

Conversation

desmonddak
Copy link
Contributor

Description & Motivation

Parallel prefix trees implementing adders, priorityencoder, incrementer, decrementer, and orscan

Related Issue(s)

#12

Testing

Tests included for each component with each flavor of prefix tree.

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

No.

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

Yes. The new components have updated documentation, and an attempt at making the configurator work with the adder.

@@ -10,6 +10,7 @@ environment:
sdk: '>=3.0.0 <4.0.0'

dependencies:
collection: ^1.18.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-note: pending open-source dependency review (already submitted, awaiting approval)

Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Nice!

@desmonddak desmonddak merged commit 8beecb7 into intel:main Feb 6, 2024
4 checks passed
@desmonddak desmonddak deleted the simpler-prefix-tree-checkin branch March 1, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants