Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parallel prefix operations #51

Closed
wants to merge 60 commits into from
Closed

parallel prefix operations #51

wants to merge 60 commits into from

Conversation

desmonddak
Copy link
Contributor

Description & Motivation

Components based on prefix tree computation: PPAdder, PPIncr, PPDecr, PPOrscan, PriorityEncoder.
Uses Ripple, Sklansky, KoggeStone, and BrentKung prefix tree patterns.

Related Issue(s)

#12

Testing

Tests included for each component with each flavor of prefix tree.

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

No

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

Yes. Documentation for the components, plus a generator for one Adder schematic to test publication.

@desmonddak desmonddak requested a review from mkorbel1 October 3, 2023 21:55
Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition to the library!

CONTRIBUTING.md Outdated Show resolved Hide resolved
lib/src/parallel_prefix_operations.dart Show resolved Hide resolved
lib/src/parallel_prefix_operations.dart Outdated Show resolved Hide resolved
lib/src/parallel_prefix_operations.dart Outdated Show resolved Hide resolved
doc/components/parallel_prefix_operations.md Show resolved Hide resolved
@@ -10,6 +10,7 @@ environment:
sdk: '>=2.18.0 <3.0.0'

dependencies:
collection: ^1.18.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: need to update open-source dependencies prior to merge (I'll take care of it, just marking it here so I don't forget)

test/parallel_prefix_operations_test.dart Outdated Show resolved Hide resolved
@desmonddak desmonddak requested a review from mkorbel1 October 5, 2023 18:21
Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good now! Just a few things to change

CONTRIBUTING.md Outdated Show resolved Hide resolved
doc/components/parallel_prefix_operations.md Outdated Show resolved Hide resolved
lib/src/parallel_prefix_operations.dart Outdated Show resolved Hide resolved
lib/src/parallel_prefix_operations.dart Outdated Show resolved Hide resolved
lib/src/parallel_prefix_operations.dart Outdated Show resolved Hide resolved
lib/src/parallel_prefix_operations.dart Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
conflicts.txt Outdated Show resolved Hide resolved
doc/onehot.md Outdated Show resolved Hide resolved
tool/converters/verilog_json.sh Outdated Show resolved Hide resolved
tool/gh_codespaces/run_setup.sh Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to add this file to lib/rohd_hcl.dart to expose it as a public API

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's weird that this (and some other) files are showing up as a diff from main. If you just do a merge or rebase with main does this go away?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The merge failed so it required manual changes. The PR is quite stale, so there are more and more conflicts.
Some files were moved in main (e.g. one_hot.dart), so I removed them from this branch.
We should go through a list of changed files before final merge and make sure this branch is not changing files we do not expect.


Each of these operations can be implemented with different ['ParallelPrefix'] types:

- ['Ripple'](https://intel.github.io/rohd-hcl/rohd_hcl/Ripple-class.html)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're still hitting that link issue I guess since the links don't exist at the time of the PR. You could just ditch links that don't (yet) exist and list them as available types rather than link to them?

Or we could just make this PR the one that disables link checking in markdown files?

@desmonddak desmonddak closed this Feb 5, 2024
@desmonddak
Copy link
Contributor Author

merge failures highlighted a lot of older code in my branch -- it would be easier to resync my fork and push the latest files for prefix.

@desmonddak desmonddak deleted the prefix-tree branch March 1, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants