-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parallel prefix operations #51
Conversation
Use d3-hwschematic source rather than our archive of it.
Synthesis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition to the library!
@@ -10,6 +10,7 @@ environment: | |||
sdk: '>=2.18.0 <3.0.0' | |||
|
|||
dependencies: | |||
collection: ^1.18.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: need to update open-source dependencies prior to merge (I'll take care of it, just marking it here so I don't forget)
…into prefix-tree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good now! Just a few things to change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to add this file to lib/rohd_hcl.dart
to expose it as a public API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's weird that this (and some other) files are showing up as a diff from main
. If you just do a merge or rebase with main
does this go away?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The merge failed so it required manual changes. The PR is quite stale, so there are more and more conflicts.
Some files were moved in main (e.g. one_hot.dart), so I removed them from this branch.
We should go through a list of changed files before final merge and make sure this branch is not changing files we do not expect.
|
||
Each of these operations can be implemented with different ['ParallelPrefix'] types: | ||
|
||
- ['Ripple'](https://intel.github.io/rohd-hcl/rohd_hcl/Ripple-class.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're still hitting that link issue I guess since the links don't exist at the time of the PR. You could just ditch links that don't (yet) exist and list them as available types rather than link to them?
Or we could just make this PR the one that disables link checking in markdown files?
merge failures highlighted a lot of older code in my branch -- it would be easier to resync my fork and push the latest files for prefix. |
Description & Motivation
Components based on prefix tree computation: PPAdder, PPIncr, PPDecr, PPOrscan, PriorityEncoder.
Uses Ripple, Sklansky, KoggeStone, and BrentKung prefix tree patterns.
Related Issue(s)
#12
Testing
Tests included for each component with each flavor of prefix tree.
Backwards-compatibility
No
Documentation
Yes. Documentation for the components, plus a generator for one Adder schematic to test publication.