Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rohd-hcl: find #37

Merged
merged 22 commits into from
Oct 12, 2023
Merged

rohd-hcl: find #37

merged 22 commits into from
Oct 12, 2023

Conversation

RPG-coder-intc
Copy link
Contributor

Description & Motivation

Find

  • Count 0s or 1s
  • Find First 0s or 1s
  • Find Nth 0s or 1s

Testing

Added test under find_test.dart

Documentation

TBD

@RPG-coder-intc
Copy link
Contributor Author

@mkorbel1 here is my PR :)

lib/src/find.dart Outdated Show resolved Hide resolved
lib/src/find.dart Outdated Show resolved Hide resolved
lib/src/find.dart Outdated Show resolved Hide resolved
lib/src/find.dart Outdated Show resolved Hide resolved
lib/src/find.dart Outdated Show resolved Hide resolved
lib/src/find.dart Outdated Show resolved Hide resolved
lib/src/find.dart Outdated Show resolved Hide resolved
lib/src/find.dart Outdated Show resolved Hide resolved
lib/src/find.dart Outdated Show resolved Hide resolved
Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress!

lib/rohd_hcl.dart Show resolved Hide resolved
lib/src/find.dart Outdated Show resolved Hide resolved
lib/src/count.dart Outdated Show resolved Hide resolved
lib/src/count.dart Outdated Show resolved Hide resolved
lib/rohd_hcl.dart Show resolved Hide resolved
lib/src/find.dart Outdated Show resolved Hide resolved
test/count_test.dart Show resolved Hide resolved
test/count_test.dart Outdated Show resolved Hide resolved
test/find_test.dart Outdated Show resolved Hide resolved
test/find_test.dart Show resolved Hide resolved
@RPG-coder-intc RPG-coder-intc mentioned this pull request Sep 28, 2023
@RPG-coder-intc RPG-coder-intc changed the title [rohd-hcl] find feature rohd-hcl: find Sep 28, 2023
test/count_test.dart Outdated Show resolved Hide resolved
@mkorbel1
Copy link
Contributor

Might want to pull from main to make sure no merge conflicts

Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good in the right direction!

lib/src/one_hot.dart Show resolved Hide resolved
lib/src/one_hot.dart Outdated Show resolved Hide resolved
lib/src/find.dart Outdated Show resolved Hide resolved
test/find_test.dart Outdated Show resolved Hide resolved
test/find_test.dart Outdated Show resolved Hide resolved
test/find_test.dart Outdated Show resolved Hide resolved
lib/src/one_hot.dart Outdated Show resolved Hide resolved
@mkorbel1 mkorbel1 merged commit 6b9313b into intel:main Oct 12, 2023
2 checks passed
@mkorbel1 mkorbel1 linked an issue Dec 28, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find N'th bit=X from start/end
2 participants