Gated counter and toggle gate #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desmonddak
reviewed
Oct 30, 2024
desmonddak
reviewed
Oct 30, 2024
| The `ToggleGate` component is intended to help save power by avoiding unnecessary toggles through combinational logic. It accomplishes this by flopping the previous value of data and muxing the previous value to the `gatedData` output if the `enable` is low. By default, the flops within the `ToggleGate` are also clock gated for extra power savings, but it can be controlled via a `ClockGateControlInterface`. | ||
|
|
||
| As an example use case, if you have a large arithmetic unit but only care about the result when a `valid` bit is high, you could use a `ToggleGate` so that the inputs to that combinational logic do not change unless `valid` is high. | ||
|
|
There was a problem hiding this comment.
Could this be an interface?
There was a problem hiding this comment.
can you elaborate? what do you mean?
desmonddak
reviewed
Oct 30, 2024
desmonddak
reviewed
Oct 30, 2024
desmonddak
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Only a few comments, mostly questions as to new things I learned from this code (like @VisibleForTesting).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
Introduces two new components:
ToggleGatewhich helps avoid toggles on combinational hardware when it's not necessaryGatedCounterwhich partitions the flops into two groups and clock gates them independently as neededRelated Issue(s)
Found intel/rohd#516 during development of random tests on the
GatedCounterTesting
Lots of unit tests and random tests
Backwards-compatibility
No
Documentation
Yes, needs API docs and component docs