Skip to content

Commit

Permalink
Update analysis options and doc checks for Dart 3.3.0 (#80)
Browse files Browse the repository at this point in the history
  • Loading branch information
mkorbel1 authored Feb 26, 2024
1 parent a64dc80 commit fc7ece0
Show file tree
Hide file tree
Showing 4 changed files with 227 additions and 159 deletions.
3 changes: 3 additions & 0 deletions .github/configs/mlc_config.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
"ignorePatterns": [
{
"pattern":"^https://www.intel.com/content/www/us/en/security-center/vulnerability-handling-guidelines.html$"
},
{
"pattern":"^https://stackoverflow.com"
}
]
}
8 changes: 2 additions & 6 deletions analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,17 @@ analyzer:
exclude:
- confapp/**

# keep up to date, matching https://dart-lang.github.io/linter/lints/options/options.html
# keep up to date, matching https://dart.dev/tools/linter-rules/all
# some lints are not yet available, so disabled and marked with [not currently recognized]
linter:
rules:
- always_declare_return_types
- always_put_control_body_on_new_line
- always_put_required_named_parameters_first
- always_require_non_null_named_parameters
# - always_specify_types
- always_use_package_imports
- annotate_overrides
- annotate_redeclares
# - avoid_annotating_with_dynamic
- avoid_bool_literals_in_conditional_expressions
- avoid_catches_without_on_clauses
Expand All @@ -45,8 +45,6 @@ linter:
- avoid_relative_lib_imports
- avoid_renaming_method_parameters
- avoid_return_types_on_setters
- avoid_returning_null
- avoid_returning_null_for_future
- avoid_returning_null_for_void
- avoid_returning_this
- avoid_setters_without_getters
Expand Down Expand Up @@ -94,15 +92,13 @@ linter:
- implicit_call_tearoffs
- implicit_reopen
- invalid_case_patterns
# - iterable_contains_unrelated_type [deprecated]
- join_return_with_assignment
- leading_newlines_in_multiline_strings
- library_annotations
- library_names
- library_prefixes
- library_private_types_in_public_api
- lines_longer_than_80_chars
# - list_remove_unrelated_type [deprecated]
- literal_only_boolean_expressions
- matching_super_parameters
- missing_whitespace_between_adjacent_strings
Expand Down
2 changes: 1 addition & 1 deletion tool/gh_actions/check_documentation.sh
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ set -euo pipefail
output=$(dart doc 2>&1 | tee)

# In case of problems, the searched substring will not be found.
if echo "${output}" | grep --silent 'no issues found'; then
if echo "${output}" | grep --silent -e 'no issues found' -e 'Success!'; then
echo 'Documentation check passed!'
else
echo "${output}"
Expand Down
Loading

0 comments on commit fc7ece0

Please sign in to comment.