Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove synchronize for pack_unpack_tensor_with_numpy #2070

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Kaihui-intel
Copy link
Contributor

Type of Change

feature or bug fix or documentation or validation or others
API changed or not

Description

detail description

Expected Behavior & Potential Risk

the expected behavior that triggered by this PR

How has this PR been tested?

how to reproduce the test (including hardware information)

Dependency Change?

any library dependency introduced or removed

Signed-off-by: Kaihui-intel <[email protected]>
Signed-off-by: Kaihui-intel <[email protected]>
@Kaihui-intel Kaihui-intel changed the title remove synchronize for unpack_tensor_with_numpy remove synchronize for pack/unpack_tensor_with_numpy Nov 20, 2024
@Kaihui-intel Kaihui-intel changed the title remove synchronize for pack/unpack_tensor_with_numpy remove synchronize for pack\unpack_tensor_with_numpy Nov 20, 2024
@Kaihui-intel Kaihui-intel changed the title remove synchronize for pack\unpack_tensor_with_numpy remove synchronize for pack_unpack_tensor_with_numpy Nov 20, 2024
@xin3he
Copy link
Contributor

xin3he commented Nov 21, 2024

@Kaihui-intel let's wait till the Habana software 1.19.0 is merged back.

@xin3he xin3he added the Related to 1.19.0 Will conflict with 1.19.0 or also exist in 1.19.0 label Nov 21, 2024
@thuang6
Copy link
Contributor

thuang6 commented Nov 22, 2024

could you give more background on this PR? why it is related to 1.19? is it expected to be cherry-picked to 1.19 release branch in INC fork?

@Kaihui-intel
Copy link
Contributor Author

This PR is related to version 1.19 because it addresses a performance optimization related to unnecessary synchronization. The synchronize operation impacts the time spent on unpacking tensors on the HPU, and the unpack_tensor_with_numpy function, which only occurs on the CPU, does not require this synchronization. Therefore, the synchronize call is redundant and can be removed to improve efficiency.
As for the cherry-pick, it needs to be answered by @xin3he

@xin3he
Copy link
Contributor

xin3he commented Nov 25, 2024

@thuang6 it's related with AutoRound PR and has conflict with it. so we should not merge this PR and wait util the AutoRound PR is cherry-picked back.
https://github.com/habana-internal/neural-compressor-fork/pull/25

@chensuyue chensuyue added this to the 3.2 milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Related to 1.19.0 Will conflict with 1.19.0 or also exist in 1.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants