Skip to content
This repository has been archived by the owner on Jan 7, 2023. It is now read-only.

rename lib name to gralloc.broxton #91

Open
wants to merge 1 commit into
base: android10-release
Choose a base branch
from
Open

rename lib name to gralloc.broxton #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 5 additions & 47 deletions Android.bp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,36 +2,21 @@
// found in the LICENSE file.

cc_defaults {
name: "gralloc.minigbm_intel_defaults",
name: "gralloc.minigbm_intel_defaults_pri",
cflags: ["-DDRV_I915"],
}

cc_defaults {
name: "gralloc.minigbm_meson_defaults",
cflags: ["-DDRV_MESON"],
}

cc_defaults {
name: "gralloc.minigbm_defaults",
name: "gralloc.minigbm_defaults_pri",

srcs: [
"amdgpu.c",
"drv.c",
"evdi.c",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also delete evdi.c

"exynos.c",
"helpers_array.c",
"helpers.c",
"i915.c",
"marvell.c",
"mediatek.c",
"meson.c",
"msm.c",
"nouveau.c",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nouveau is for nvidia card, should also be deleted

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this blueprint file is from upstream, it would be best to keep all these lines and avoid number of changes against upstream. It would be then easier to rebase in the future when we update our minigbm from upstream?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to we need change the Android.bp, then we prefer to keep the Android.bp clean.

"radeon.c",
"rockchip.c",
"tegra.c",
"udl.c",
"vc4.c",
"vgem.c",
"virtio_gpu.c",

Expand Down Expand Up @@ -76,15 +61,10 @@ cc_defaults {
}

cc_library_shared {
name: "gralloc.minigbm",
defaults: ["gralloc.minigbm_defaults"],
}

cc_library_shared {
name: "gralloc.minigbm_intel",
name: "gralloc.intel",
defaults: [
"gralloc.minigbm_defaults",
"gralloc.minigbm_intel_defaults",
"gralloc.minigbm_defaults_pri",
"gralloc.minigbm_intel_defaults_pri",
],
enabled: false,
arch: {
Expand All @@ -96,25 +76,3 @@ cc_library_shared {
},
},
}

cc_library_shared {
name: "gralloc.minigbm_meson",
defaults: [
"gralloc.minigbm_defaults",
"gralloc.minigbm_meson_defaults",
],
}

cc_library_shared {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better still keep libminigbm, which can be used as test purpose

name: "libminigbm",
defaults: ["gralloc.minigbm_defaults"],
shared_libs: ["liblog"],
static_libs: ["libdrm"],

srcs: [
"gbm.c",
"gbm_helpers.c",
],

export_include_dirs: ["."],
}