Do not advertise support for nonexistent alpha channels in #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulinjie
reviewed
May 29, 2020
| @@ -2279,20 +2294,20 @@ DdiMedia_CreateSurfaces2( | |||
| expected_fourcc = VA_FOURCC_Y216; | |||
| break; | |||
| case VA_RT_FORMAT_YUV444: | |||
| expected_fourcc = VA_FOURCC_444P; | |||
| expected_fourcc = VA_FOURCC_XYUV; | |||
There was a problem hiding this comment.
What if the decoder wants a VA_FOURCC_444P?
IIRC, JPEG decoding for 444P seems to require VA_FOURCC_444P. (I could be wrong since it's been some time since my last check)
There was a problem hiding this comment.
Thanks linjie's input.
I will use VA_FOURCC_444P as default for yuv444.
If you want to xyuv, you can use VA_FOURCC_XYUV directly.
fulinjie
reviewed
May 29, 2020
weizhu-intel
force-pushed
the
wayne_media
branch
3 times, most recently
from
5435330 to
9fdbb95
Compare
decode/encode Change decode/encode in YUV 4:4:4 formats to only support surfaces with no alpha channel, since there is no alpha support. Signed-off-by: Mark Thompson <[email protected]>
FurongZhang
reviewed
Jul 20, 2020
| case Media_Format_Y410: | ||
| return VA_FOURCC_Y410; | ||
| case Media_Format_XV30: | ||
| return VA_FOURCC_XV30; |
There was a problem hiding this comment.
What is XV30? XV48? Could you please provide some background of these definitions?
There was a problem hiding this comment.
FuRong,
Before our video driver advertise to support alpha channel, but actually not.
So now we remove all alpha channel support.
XV30 is for Y410, and XV48 is for Y416.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decode/encode
Change decode/encode in YUV 4:4:4 formats to only support surfaces with
no alpha channel, since there is no alpha support.
Signed-off-by: Mark Thompson [email protected]