replace the swizzle function to Mos_SwizzleData #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes intel#715 the swizzleSurface function will call GmmLib::GmmResourceInfoCommon::CpuBlt and CpuSwizzleBlt, in this function _mm_storeu_si128 will write some invalid memory it is not rootcause, jus a finding. should not merged until real rootcause is found Signed-off-by: XinfengZhang <[email protected]>
dmitryermilov
suggested changes
Sep 22, 2019
There was a problem hiding this comment.
Hi @XinfengZhang , this seems to be a workaround. I'd like to remind that while GmmLib::GmmResourceInfoCommon::CpuBlt has SSE optimization, Mos_SwizzleData makes simple per pixel copy. Mos_SwizzleData will kill performance. Why not to fix GmmLib::GmmResourceInfoCommon::CpuBlt?
|
@dmitryermilov , in my comments, I already marked it "jus a finding. should not merged until real rootcause is found" |
|
Hi Carl, Yes, I missed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #715
the swizzleSurface function will call GmmLib::GmmResourceInfoCommon::CpuBlt
and CpuSwizzleBlt, in this function _mm_storeu_si128 will write some invalid memory
it is not rootcause, jus a finding. should not merged until real rootcause is found
Signed-off-by: XinfengZhang [email protected]