[Encode] Fix ACM multi-channel AVC encode performance degradation #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bai-isaac
suggested changes
Jan 16, 2025
| @@ -443,7 +443,6 @@ static bool InitTglMediaWaExt(struct GfxDeviceInfo *devInfo, | |||
| } | |||
|
|
|||
| MEDIA_WR_WA(waTable, WaEnableVPPCopy, 1); | |||
| MEDIA_WR_WA(waTable, Wa_AvcUnalignedHeight, 1); | |||
There was a problem hiding this comment.
InitTglMediaWaExt is a common function for gen12, include TGL, DG2 ... please only remove for DG2, thanks.
hoesheng
force-pushed
the
fix_acm_encode_perf
branch
from
0973462 to
dbf4080
Compare
disable DG2 Height alignment WA Signed-off-by: Hoe, Sheng Yang <[email protected]>
hoesheng
force-pushed
the
fix_acm_encode_perf
branch
from
dbf4080 to
f905a35
Compare
bai-isaac
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disable DG2 Height alignment WA