-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add registry to configure MTL Media CCS #1760
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you give more details why you need this change? why you care and want to change CCS node? Any background will help me understand.
__MEDIA_USER_FEATURE_VALUE_ENABLE_MEDIA_CCS, | ||
MediaUserSetting::Group::Device); | ||
|
||
if (value > 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trying to understand, default Value is 0, when you read a data which is none 0, then you will force a 0 ? this means you want to make FtrCCSNode to 0 in Debug/Release version of driver?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made a mistake. The default value of FtrCCSNode is 1. I have it updated in the next patch and added a comment accordingly. For debug/internal-release build, we could use registry key to enable/disable CCS.
Signed-off-by: Cheah, Vincent Beng Keat <[email protected]>
3691490
to
06a72a3
Compare
Here is some background story that I've gotten from my colleague. I'll add you into the email thread. We would like to add in new registry key to disable MTL Media CCS, just in case user would to disable it by themselves. |
Default CCS is enabled when compiled in debug/internal-release build.
The registry key allows user to configure them accordingly.