Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add registry to configure MTL Media CCS #1760

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Conversation

vcheah
Copy link
Contributor

@vcheah vcheah commented Jan 9, 2024

Default CCS is enabled when compiled in debug/internal-release build.
The registry key allows user to configure them accordingly.

Copy link
Contributor

@Guangyao-Bai Guangyao-Bai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you give more details why you need this change? why you care and want to change CCS node? Any background will help me understand.

__MEDIA_USER_FEATURE_VALUE_ENABLE_MEDIA_CCS,
MediaUserSetting::Group::Device);

if (value > 1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trying to understand, default Value is 0, when you read a data which is none 0, then you will force a 0 ? this means you want to make FtrCCSNode to 0 in Debug/Release version of driver?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a mistake. The default value of FtrCCSNode is 1. I have it updated in the next patch and added a comment accordingly. For debug/internal-release build, we could use registry key to enable/disable CCS.

Signed-off-by: Cheah, Vincent Beng Keat <[email protected]>
@vcheah vcheah force-pushed the ccs branch 2 times, most recently from 3691490 to 06a72a3 Compare April 18, 2024 12:15
@vcheah
Copy link
Contributor Author

vcheah commented Apr 18, 2024

can you give more details why you need this change? why you care and want to change CCS node? Any background will help me understand.

Here is some background story that I've gotten from my colleague. I'll add you into the email thread.

We would like to add in new registry key to disable MTL Media CCS, just in case user would to disable it by themselves.
Previous we are hitting some media issue related to Media CCS in MTL platform causing GPU hung issue, we end up have to disable MTL Media CCS in media-driver side. Recently Tong Liang told us got fixed in kernel 6.5 version, so we enable back MTL Media CCS in our Ubuntu BKC. We would like still to keep this registry key in media driver side, to allow user to disable MTL Media CCS if needed that time.

@XinfengZhang XinfengZhang requested a review from MicroYY May 22, 2024 14:00
@MicroYY MicroYY added the verifying PR: fix ready and verifying with build/test label May 27, 2024
@intel-mediadev intel-mediadev merged commit 12561f6 into intel:master Jun 10, 2024
13 checks passed
@vcheah vcheah deleted the ccs branch June 11, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verifying PR: fix ready and verifying with build/test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants