Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Encode] Report sub features for HEVC #1312

Merged
merged 1 commit into from
Dec 18, 2021

Conversation

Tianhaol
Copy link
Contributor

Fill in VAConfigAttribValEncHEVCFeatures and VAConfigAttribValEncHEVCBlockSizes
with the approriate values for HEVC VDENC.
Fixes #1190.

@Tianhaol
Copy link
Contributor Author

@thomasli21801 @Xiaogang-Li Could you help to review this PR?

Copy link
Contributor

@XinfengZhang XinfengZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this already in 2.12 release

media_driver/linux/gen12/ddi/media_libva_caps_g12.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@XinfengZhang XinfengZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please help to change the commit message to HEVC VME

@Tianhaol
Copy link
Contributor Author

please help to change the commit message to HEVC VME

This PR is both for VDENC and VME, so I remove VDENC.

@XinfengZhang XinfengZhang added the verifying PR: fix ready and verifying with build/test label Dec 15, 2021
@feiwan1
Copy link
Contributor

feiwan1 commented Dec 16, 2021

Hi @Tianhaol , I used ffmpeg-vaapi to verified your patch on my TGL(device id 9a49 (rev 01)), issue #1190 still exist for LP mode. While, VME looks good now. Could you help to verify this in your side? Thanks.

ffmpeg patch:
intel-media-ci/ffmpeg#469

LP mode cmd:
ffmpeg -hwaccel vaapi -init_hw_device vaapi=hw:/dev/dri/renderD128 -hwaccel_output_format vaapi -v verbose -f rawvideo -pix_fmt nv12 -s:v 1920x1080 -r:v 30 -i 1920x1080_nv12.yuv -vf 'format=nv12,hwupload' -an -c:v hevc_vaapi -profile:v main -rc_mode CBR -b:v 5000k -maxrate 7000k -low_power 1 -vframes 1 -y out.h265

VME mode cmd:
ffmpeg -hwaccel vaapi -init_hw_device vaapi=hw:/dev/dri/renderD128 -hwaccel_output_format vaapi -v verbose -f rawvideo -pix_fmt nv12 -s:v 1920x1080 -r:v 30 -i 1920x1080_nv12.yuv -vf 'format=nv12,hwupload' -an -c:v hevc_vaapi -profile:v main -rc_mode CBR -b:v 5000k -maxrate 7000k -low_power 0 -vframes 1 -y out.h265

@Tianhaol
Copy link
Contributor Author

Hi @Tianhaol , I used ffmpeg-vaapi to verified your patch on my TGL(device id 9a49 (rev 01)), issue #1190 still exist for LP mode. While, VME looks good now. Could you help to verify this in your side? Thanks.

ffmpeg patch: intel-media-ci/ffmpeg#469

LP mode cmd: ffmpeg -hwaccel vaapi -init_hw_device vaapi=hw:/dev/dri/renderD128 -hwaccel_output_format vaapi -v verbose -f rawvideo -pix_fmt nv12 -s:v 1920x1080 -r:v 30 -i 1920x1080_nv12.yuv -vf 'format=nv12,hwupload' -an -c:v hevc_vaapi -profile:v main -rc_mode CBR -b:v 5000k -maxrate 7000k -low_power 1 -vframes 1 -y out.h265

VME mode cmd: ffmpeg -hwaccel vaapi -init_hw_device vaapi=hw:/dev/dri/renderD128 -hwaccel_output_format vaapi -v verbose -f rawvideo -pix_fmt nv12 -s:v 1920x1080 -r:v 30 -i 1920x1080_nv12.yuv -vf 'format=nv12,hwupload' -an -c:v hevc_vaapi -profile:v main -rc_mode CBR -b:v 5000k -maxrate 7000k -low_power 0 -vframes 1 -y out.h265

@feiwan1 @XinfengZhang I run case on TGL with these two variables 2/3 for VDENC. 3: corruption, 2: no corruption. I thought they should be assigned to 2. Do you have any comments?

@feiwan1
Copy link
Contributor

feiwan1 commented Dec 16, 2021

Hi @Tianhaol , I used ffmpeg-vaapi to verified your patch on my TGL(device id 9a49 (rev 01)), issue #1190 still exist for LP mode. While, VME looks good now. Could you help to verify this in your side? Thanks.
ffmpeg patch: intel-media-ci/ffmpeg#469
LP mode cmd: ffmpeg -hwaccel vaapi -init_hw_device vaapi=hw:/dev/dri/renderD128 -hwaccel_output_format vaapi -v verbose -f rawvideo -pix_fmt nv12 -s:v 1920x1080 -r:v 30 -i 1920x1080_nv12.yuv -vf 'format=nv12,hwupload' -an -c:v hevc_vaapi -profile:v main -rc_mode CBR -b:v 5000k -maxrate 7000k -low_power 1 -vframes 1 -y out.h265
VME mode cmd: ffmpeg -hwaccel vaapi -init_hw_device vaapi=hw:/dev/dri/renderD128 -hwaccel_output_format vaapi -v verbose -f rawvideo -pix_fmt nv12 -s:v 1920x1080 -r:v 30 -i 1920x1080_nv12.yuv -vf 'format=nv12,hwupload' -an -c:v hevc_vaapi -profile:v main -rc_mode CBR -b:v 5000k -maxrate 7000k -low_power 0 -vframes 1 -y out.h265

@feiwan1 @XinfengZhang I run case on TGL with these two variables 2/3 for VDENC. 3: corruption, 2: no corruption. I thought they should be assigned to 2. Do you have any comments?

Yes, it can solve the issue from my testing.

Fill in VAConfigAttribValEncHEVCFeatures and VAConfigAttribValEncHEVCBlockSizes
with the approriate values for HEVC.
Fixes intel#1190.
@feiwan1
Copy link
Contributor

feiwan1 commented Dec 17, 2021

Test looks good for me now. Thanks @Tianhaol .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verifying PR: fix ready and verifying with build/test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Corrupted HEVC encoded files on Tiger Lake
5 participants