-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Encode] Report sub features for HEVC #1312
Conversation
@thomasli21801 @Xiaogang-Li Could you help to review this PR? |
e408f7c
to
6dfb195
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this already in 2.12 release
6dfb195
to
092d721
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please help to change the commit message to HEVC VME
092d721
to
4400f4c
Compare
This PR is both for VDENC and VME, so I remove VDENC. |
Hi @Tianhaol , I used ffmpeg-vaapi to verified your patch on my TGL(device id 9a49 (rev 01)), issue #1190 still exist for LP mode. While, VME looks good now. Could you help to verify this in your side? Thanks. ffmpeg patch: LP mode cmd: VME mode cmd: |
@feiwan1 @XinfengZhang I run case on TGL with these two variables 2/3 for VDENC. 3: corruption, 2: no corruption. I thought they should be assigned to 2. Do you have any comments? |
Yes, it can solve the issue from my testing. |
Fill in VAConfigAttribValEncHEVCFeatures and VAConfigAttribValEncHEVCBlockSizes with the approriate values for HEVC. Fixes intel#1190.
4400f4c
to
dccdf63
Compare
Test looks good for me now. Thanks @Tianhaol . |
Fill in VAConfigAttribValEncHEVCFeatures and VAConfigAttribValEncHEVCBlockSizes
with the approriate values for HEVC VDENC.
Fixes #1190.