Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Encode] report sub features for HEVC VDENC #1121

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Encode] report sub features for HEVC VDENC #1121

wants to merge 1 commit into from

Conversation

Tianhaol
Copy link
Contributor

@Tianhaol Tianhaol commented Jan 7, 2021

Fill in VAConfigAttribValEncHEVCFeatures and VAConfigAttribValEncHEVCBlockSizes
with the approriate values for HEVC VDENC.

@Tianhaol Tianhaol changed the title [Encode] query sub feature for HEVC VDENC [Encode] report sub features for HEVC VDENC Jan 7, 2021
@XinfengZhang XinfengZhang mentioned this pull request Jan 11, 2021
Merged
@Tianhaol Tianhaol force-pushed the sub_feature branch 2 times, most recently from 8f276a9 to 2680ab4 Compare January 13, 2021 01:38
@fhvwy
Copy link
Contributor

fhvwy commented Jan 18, 2021

The latest version of the attributes remove log2_min_cu_qp_delta_size_minus3 as discussed at intel/libva#385 (comment) , so that need not be included here.

The rest of this looks good to me, thank you.

(I suppose the attributes will need to have more versions for each of the hardware platforms supported by the driver - Gen12 with shaders, Gen11 in both modes, Gen9.)

@XinfengZhang XinfengZhang mentioned this pull request Oct 26, 2021
Closed
@XinfengZhang XinfengZhang mentioned this pull request Nov 11, 2021
Closed
feiwan1
feiwan1 reviewed Nov 12, 2021
View reviewed changes
media_driver/linux/gen12/ddi/media_libva_caps_g12.cpp
}
break;
}
#endif
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May need to call GetPlatformSpecificAttrib with type VAConfigAttribEncHEVCFeatures/VAConfigAttribEncHEVCBlockSizes in CreateEncAttributes to register them in attribList.

Also could you help to add the two attribute setting for non-low-power mode?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registering them in attribList is feasible, will update this PR after verify them.

Supporting these two attributes setting for non-low-power mode, we need setup a meeting to discuss.

@Tianhaol
[Encode] Report sub features for HEVC VDENC
8675528 
Fill in VAConfigAttribValEncHEVCFeatures and VAConfigAttribValEncHEVCBlockSizes
with the approriate values for HEVC VDENC.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiwan1 feiwan1 feiwan1 left review comments

@thomasli21801 thomasli21801 thomasli21801 approved these changes

@XinfengZhang XinfengZhang XinfengZhang approved these changes

@Xiaogangli-intel Xiaogangli-intel Awaiting requested review from Xiaogangli-intel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Tianhaol @fhvwy @feiwan1 @XinfengZhang @thomasli21801