You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One more thing. This change a relatively simple, it's a proxy to DdiMedia_CopyInternal which seems to do all work. So reviewing this PR only , it's impossible to identify which sub-features of vaCopy the current PR introduce. Under sub-features I mean VA_COPY_SYNC_BLOCK/VA_COPY_SYNC_NONBLOCK/VA_COPY_MODE_BALANCE/etc , VACopyObjectBuffer/VACopyObjectSurface. Could you describe it in git commit message ?
One more thing. This change a relatively simple, it's a proxy to DdiMedia_CopyInternal which seems to do all work. So reviewing this PR only , it's impossible to identify which sub-features of vaCopy the current PR introduce. Under sub-features I mean VA_COPY_SYNC_BLOCK/VA_COPY_SYNC_NONBLOCK/VA_COPY_MODE_BALANCE/etc , VACopyObjectBuffer/VACopyObjectSurface. Could you describe it in git commit message ?
sample add in libva-utils PR, and VACopy related definition is in libva PR. Do you mean we should add them in this commit again?
One more thing. This change a relatively simple, it's a proxy to DdiMedia_CopyInternal which seems to do all work. So reviewing this PR only , it's impossible to identify which sub-features of vaCopy the current PR introduce. Under sub-features I mean VA_COPY_SYNC_BLOCK/VA_COPY_SYNC_NONBLOCK/VA_COPY_MODE_BALANCE/etc , VACopyObjectBuffer/VACopyObjectSurface. Could you describe it in git commit message ?
sample add in libva-utils PR, and VACopy related definition is in libva PR. Do you mean we should add them in this commit again?
If full support of all underlying vaCopy features is appeared by this PR - then I don't think we need additional info in git message. But even above you wrote "currently, buffer copy is not supported by vaCopy". I assume such things better to capture in git message, together with other limitations if any.
One more thing. This change a relatively simple, it's a proxy to DdiMedia_CopyInternal which seems to do all work. So reviewing this PR only , it's impossible to identify which sub-features of vaCopy the current PR introduce. Under sub-features I mean VA_COPY_SYNC_BLOCK/VA_COPY_SYNC_NONBLOCK/VA_COPY_MODE_BALANCE/etc , VACopyObjectBuffer/VACopyObjectSurface. Could you describe it in git commit message ?
sample add in libva-utils PR, and VACopy related definition is in libva PR. Do you mean we should add them in this commit again?
If full support of all underlying vaCopy features is appeared by this PR - then I don't think we need additional info in git message. But even above you wrote "currently, buffer copy is not supported by vaCopy". I assume such things better to capture in git message, together with other limitations if any.
okay, will add some notification in this git commit message.
add New libva API vaCopy DDI implementation.
1. only support VACopyObjectSurface copy, VACopyObjectBuffer copy is not ready since it could be handled by CPU.
2. currently, copy sync handle mode is absent, app can call vaSyncSurface to make sure copy complete.
3. linked libva PR: intel/libva#243
4. linked libva-utils sample code PR: intel/libva-utils#203
verifyingPR: fix ready and verifying with build/test
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add mediaCopy ddi implementation.
linked libva PR: intel/libva#243
add libva-utils PR: intel/libva-utils#203