Skip to content

Commit

Permalink
Revert "[Decode] SW WA for Check HuC authentication status in ACM D3 …
Browse files Browse the repository at this point in the history
…cold state"

This reverts commit intel-innersource/drivers.gpu.unified#b4440bd6b
  • Loading branch information
luleilei1 authored and intel-mediadev committed Dec 12, 2023
1 parent c822546 commit b98aa43
Show file tree
Hide file tree
Showing 13 changed files with 5 additions and 368 deletions.
1 change: 0 additions & 1 deletion media_common/agnostic/common/hw/mhw_mmio.h
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ struct MmioRegistersHuc
uint32_t hucStatusRegOffset = 0;
uint32_t hucUKernelHdrInfoRegOffset = 0;
uint32_t hucStatus2RegOffset = 0;
uint32_t hucLoadInfoOffset = 0;
};

//!
Expand Down
38 changes: 0 additions & 38 deletions media_driver/agnostic/gen12/hw/mhw_mi_g12_X.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -235,44 +235,6 @@ MOS_STATUS MhwMiInterfaceG12::AddMiBatchBufferStartCmd(
return MOS_STATUS_SUCCESS;
}

MOS_STATUS MhwMiInterfaceG12::AddMiBatchBufferStartCmd(
PMOS_COMMAND_BUFFER cmdBuffer,
PMHW_BATCH_BUFFER batchBuffer,
bool useChainedBB)
{
MHW_FUNCTION_ENTER;

MHW_MI_CHK_NULL(cmdBuffer);
MHW_MI_CHK_NULL(batchBuffer);
MHW_MI_CHK_NULL(m_osInterface);
bool vcsEngineUsed =
MOS_VCS_ENGINE_USED(m_osInterface->pfnGetGpuContext(m_osInterface));

mhw_mi_g12_X::MI_BATCH_BUFFER_START_CMD cmd;
MHW_RESOURCE_PARAMS resourceParams;
MOS_ZeroMemory(&resourceParams, sizeof(resourceParams));
resourceParams.presResource = &batchBuffer->OsResource;
resourceParams.dwOffset = batchBuffer->dwOffset;
resourceParams.pdwCmd = cmd.DW1_2.Value;
resourceParams.dwLocationInCmd = 1;
resourceParams.dwLsbNum = MHW_COMMON_MI_GENERAL_SHIFT;
resourceParams.HwCommandType = vcsEngineUsed ? MOS_MI_BATCH_BUFFER_START : MOS_MI_BATCH_BUFFER_START_RCS;

MHW_MI_CHK_STATUS(AddResourceToCmd(
m_osInterface,
cmdBuffer,
&resourceParams));

// Set BB start
cmd.DW0.Obj3.SecondLevelBatchBuffer = useChainedBB ? false : true;
cmd.DW0.Obj0.AddressSpaceIndicator = !IsGlobalGttInUse();

// Send BB start command
MHW_MI_CHK_STATUS(m_osInterface->pfnAddCommand(cmdBuffer, &cmd, cmd.byteSize));

return MOS_STATUS_SUCCESS;
}

MOS_STATUS MhwMiInterfaceG12::AddMiConditionalBatchBufferEndCmd(
PMOS_COMMAND_BUFFER cmdBuffer,
PMHW_MI_CONDITIONAL_BATCH_BUFFER_END_PARAMS params)
Expand Down
5 changes: 0 additions & 5 deletions media_driver/agnostic/gen12/hw/mhw_mi_g12_X.h
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,6 @@ struct MhwMiInterfaceG12 : public MhwMiInterfaceGeneric<mhw_mi_g12_X>
PMOS_COMMAND_BUFFER cmdBuffer,
PMHW_BATCH_BUFFER batchBuffer) override;

MOS_STATUS AddMiBatchBufferStartCmd(
PMOS_COMMAND_BUFFER cmdBuffer,
PMHW_BATCH_BUFFER batchBuffer,
bool useChainedBB = false);

MOS_STATUS AddMiStoreRegisterMemCmd(
PMOS_COMMAND_BUFFER cmdBuffer,
PMHW_MI_STORE_REGISTER_MEM_PARAMS params) override;
Expand Down
3 changes: 1 addition & 2 deletions media_driver/agnostic/gen12/hw/mhw_mmio_g12.h
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,7 @@
#define HUC_UKERNEL_HDR_INFO_REG_OFFSET_NODE_1_INIT_G12 0x1C2014
#define HUC_STATUS_REG_OFFSET_NODE_1_INIT_G12 0x1C2000
#define HUC_STATUS2_REG_OFFSET_NODE_1_INIT_G12 0x1C23B0
#define HUC_LOAD_INFO_REG_OFFSET_G12 0xC1DC
#define HUC_LOAD_INFO_REG_MASK_G12 0x1


//VDBOX MFX register offsets
#define GENERAL_PURPOSE_REGISTER0_LO_OFFSET_NODE_1_INIT_G12 0x1C0600
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ void MhwVdboxHucInterfaceG12::InitMmioRegisters()
mmioRegisters->hucUKernelHdrInfoRegOffset = HUC_UKERNEL_HDR_INFO_REG_OFFSET_NODE_1_INIT_G12;
mmioRegisters->hucStatusRegOffset = HUC_STATUS_REG_OFFSET_NODE_1_INIT_G12;
mmioRegisters->hucStatus2RegOffset = HUC_STATUS2_REG_OFFSET_NODE_1_INIT_G12;
mmioRegisters->hucLoadInfoOffset = HUC_LOAD_INFO_REG_OFFSET_G12;

m_mmioRegisters[MHW_VDBOX_NODE_2] = m_mmioRegisters[MHW_VDBOX_NODE_1];
}
Expand Down

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2019-2023, Intel Corporation
* Copyright (c) 2019, Intel Corporation
*
* Permission is hereby granted, free of charge, to any person obtaining a
* copy of this software and associated documentation files (the "Software"),
Expand Down Expand Up @@ -44,24 +44,11 @@ namespace decode {
DECODE_CHK_NULL(m_s2lDmemBufferArray);
}

if (m_hucAuthPkt != nullptr)
{
// allocate resources for huc auth packet
DECODE_CHK_STATUS(m_hucAuthPkt->Init());
}

return MOS_STATUS_SUCCESS;
}

MOS_STATUS HucS2lPktM12::Destroy()
{
if (m_hucAuthPkt != nullptr)
{
// destroy resources allocated in huc auth packet
DECODE_CHK_STATUS(m_hucAuthPkt->Destroy());
MOS_Delete(m_hucAuthPkt);
}

DECODE_CHK_STATUS(m_allocator->Destroy(m_s2lDmemBufferArray));
DECODE_CHK_STATUS(HucS2lPktXe_M_Base::Destroy());
return MOS_STATUS_SUCCESS;
Expand Down Expand Up @@ -110,12 +97,6 @@ namespace decode {

DECODE_CHK_NULL(m_hucInterface);

if (m_hucAuthPkt != nullptr)
{
// add huc auth check cmds
DECODE_CHK_STATUS(m_hucAuthPkt->Execute(cmdBuffer));
}

if (prologNeeded)
{
DECODE_CHK_STATUS(AddForceWakeup(cmdBuffer, false, true));
Expand Down
Loading

0 comments on commit b98aa43

Please sign in to comment.