[Media Common][VP] clean coverity isuues mos

clean mos coverity issues
intel · Sep 5, 2023 · 7a5cb2b · 7a5cb2b
1 parent bf72cea
commit 7a5cb2b
Show file tree

Hide file tree

Showing 5 changed files with 24 additions and 7 deletions.
diff --git a/media_driver/agnostic/common/os/mos_graphicsresource.cpp b/media_driver/agnostic/common/os/mos_graphicsresource.cpp
@@ -116,6 +116,7 @@ MOS_STATUS GraphicsResource::Dump(OsContext* osContextPtr, uint32_t overrideOffs
         if (hFile != nullptr)
         {
             MosUtilities::MosCloseHandle(hFile);
+            hFile = nullptr;
         }
     }
 

diff --git a/media_driver/agnostic/common/os/mos_os_virtualengine.cpp b/media_driver/agnostic/common/os/mos_os_virtualengine.cpp
@@ -107,7 +107,7 @@ MOS_STATUS Mos_VirtualEngineInterface_Initialize(
             pVEInterf->veInterface = MOS_New(MosOsVeSinglePipeSpecific);
         }
         MOS_OS_CHK_NULL(pVEInterf->veInterface);
-        pVEInterf->veInterface->Initialize(pOsInterface->osStreamState, pVEInitParms);
+        MOS_OS_CHK_STATUS(pVEInterf->veInterface->Initialize(pOsInterface->osStreamState, pVEInitParms));
         pOsInterface->osStreamState->virtualEngineInterface = pVEInterf->veInterface;
     }
     return eStatus;

diff --git a/media_driver/agnostic/common/vp/hal/vphal_render_renderstate.h b/media_driver/agnostic/common/vp/hal/vphal_render_renderstate.h
@@ -93,7 +93,8 @@ class RenderpassData
                     // free all allocated surfaces
                     while (i > 0)
                     {
-                        MOS_FreeMemAndSetNull(TempOutputSurfaces[--i]);
+                        --i;
+                        MOS_FreeMemAndSetNull(TempOutputSurfaces[i]);
                     }
                     return MOS_STATUS_NO_SPACE;
                 }

diff --git a/media_softlet/agnostic/common/heap_manager/memory_block_manager.cpp b/media_softlet/agnostic/common/heap_manager/memory_block_manager.cpp
@@ -240,15 +240,25 @@ MOS_STATUS MemoryBlockManager::RegisterHeap(uint32_t heapId, uint32_t size , boo
 
     auto heap = MOS_New(Heap, heapId);
     HEAP_CHK_NULL(heap);
-    HEAP_CHK_STATUS(heap->RegisterOsInterface(m_osInterface));
+    eStatus = heap->RegisterOsInterface(m_osInterface);
+    if (MOS_FAILED(eStatus))
+    {
+        MOS_Delete(heap);
+        HEAP_CHK_STATUS(eStatus);
+    }
     size = MOS_ALIGN_CEIL(size, m_heapAlignment);
 
     if (hwWriteOnly)
     {
         heap->SetHeapHwWriteOnly(hwWriteOnly);
     }
 
-    HEAP_CHK_STATUS(heap->Allocate(size, m_lockHeapsOnAllocate));
+    eStatus = heap->Allocate(size, m_lockHeapsOnAllocate);
+    if (MOS_FAILED(eStatus))
+    {
+        MOS_Delete(heap);
+        HEAP_CHK_STATUS(eStatus);
+    }
 
     if (heap->IsValid())
     {
@@ -264,7 +274,12 @@ MOS_STATUS MemoryBlockManager::RegisterHeap(uint32_t heapId, uint32_t size , boo
 
         std::shared_ptr<HeapWithAdjacencyBlockList> managedHeap = nullptr;
         managedHeap = MakeShared<HeapWithAdjacencyBlockList>();
-        HEAP_CHK_NULL(managedHeap);
+        if (managedHeap == nullptr)
+        {
+            MOS_Delete(heap);
+            MOS_Delete(adjacencyListBegin);
+            HEAP_CHK_STATUS(MOS_STATUS_NULL_POINTER);
+        }
         managedHeap->m_heap = heap;
         managedHeap->m_size = managedHeap->m_heap->GetSize();
         managedHeap->m_adjacencyListBegin = adjacencyListBegin;
@@ -298,7 +313,7 @@ MOS_STATUS MemoryBlockManager::UnregisterHeap(uint32_t heapId)
         if (heapId == (*iterator)->m_heap->GetId())
         {
             bool blocksUpdated = false;
-            RefreshBlockStates(blocksUpdated);
+            HEAP_CHK_STATUS(RefreshBlockStates(blocksUpdated));
             (*iterator)->m_heap->PrepareForFree();
             m_totalSizeOfHeaps -= (*iterator)->m_heap->GetSize();
 

diff --git a/media_softlet/agnostic/common/vp/hal/feature_manager/sw_filter_pipe.cpp b/media_softlet/agnostic/common/vp/hal/feature_manager/sw_filter_pipe.cpp
@@ -732,7 +732,7 @@ MOS_STATUS SwFilterPipe::AddSwFilterUnordered(SwFilter *swFilter, bool isInputPi
 
     if (nullptr == pSubPipe && !isInputPipe)
     {
-        auto& pipes = isInputPipe ? m_InputPipes : m_OutputPipes;
+        auto& pipes = m_OutputPipes;
         SwFilterSubPipe *pipe = MOS_New(SwFilterSubPipe);
         VP_PUBLIC_CHK_NULL_RETURN(pipe);
         if ((size_t)index <= pipes.size())
-Original file line number
+Diff line change
@@ Expand Up @@
             if (hFile != nullptr)
             {
                 MosUtilities::MosCloseHandle(hFile);
+                hFile = nullptr;
             }
         }
@@ Expand Down @@