-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Write tests following the test plan for the work group memory extension #15928
Conversation
…/llvm into work_group_memory_tests
} | ||
} | ||
|
||
// Explicit instantiations for the relevant data types. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, why are these explicit instantiations necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason, when passing these kernel names to the free function queries with concrete template types, it would complain that these names do not represent kernels because they had not been instantiated yet although one would hope this instantiation would be automatic upon passing these kernel names to the queries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds like either a bug or a missing feature with free function kernels. Can you add the same comment here about removing this code when free function kernels are fully supported?
Alternatively, maybe we should just delay testing of work_group_memory
with free function kernels until there is better support for free function kernels. It seems like there are a lot of places where you need to add workarounds for missing features in free function kernels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds like either a bug or a missing feature with free function kernels. Can you add the same comment here about removing this code when free function kernels are fully supported?
Alternatively, maybe we should just delay testing of
work_group_memory
with free function kernels until there is better support for free function kernels. It seems like there are a lot of places where you need to add workarounds for missing features in free function kernels.
Sure. We can keep the test as I've put an XFAIL directive to expect failures on all platforms since support is not implemented yet.
Co-authored-by: Steffen Larsen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR adds feature tests as per the work group memory extension test plan.