Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove executable permissions of tests. #338

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Conversation

haoliang-Zhu
Copy link
Contributor

1. Remove executable permissions for all tests files. This permission will affect rpm packaging.

@xupengfe
Copy link
Contributor

Removing executable permissions of tests looks good.

And some other actions are included but commit description doesn't mention:

  1. Added the BM/tdx-compliance/tests-trigger-cpuid.sh and BM/tdx-compliance/testallcase.sh executable permissions.

  2. Code improvement for BM/tdx-compliance/tests-trigger-cpuid.sh

For points 2 and 3, it's better to split them into two commits to perform these actions.
It's best to do only one thing for one commit.

Thanks!

@haoliang-Zhu
Copy link
Contributor Author

Thank you for your suggestion, after that I will pay attention to doing only one thing per commit.

    1. Remove executable permissions for all tests files.

    Signed-off-by: Haoliang Zhu <[email protected]>
    1. Code improvement for BM/tdx-compliance/tests-trigger-cpuid.sh.

    Signed-off-by: Haoliang Zhu <[email protected]>
@ysun ysun merged commit da73c4e into intel:main Aug 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants