Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtests: add tests-guest/tests-gnr/tests-spr support #250

Merged
merged 1 commit into from
May 31, 2024

Conversation

xupengfe
Copy link
Contributor

As before runtests could only support tests-client and tests-server, now it could support tests-guest/tests-gnr/tests-spr and so on test files.

[[ "$CMDFILES" == "$TESTS_CLIENT" ]] && test_all "$TESTS_CLIENT"
[[ "$CMDFILES" == "$TESTS_SERVER" ]] && test_all "$TESTS_SERVER"
# If tests-server type will list tests-server in all subfolders
[[ "$CMDFILES" == *"-"* ]] && list_all_test_files "$CMDFILES"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @xupengfe, can we have another parameter to handle such batch testing, like '-b' ?
In that case, '-f' is for specified tests file, while runtests can run multiple tests with option '-b'.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ysun ,

-f already support this function.
For example: ./runtests -f cet/tests,umip/tests,cstate/tests-server
Is that you want?

It's already supported.

Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the usage of '-f '. However, my point is that we may NOT reuse '-f' for multiple tests. Instead, create a new option for running multiple tests.

Copy link
Contributor Author

@xupengfe xupengfe May 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok will use -t t means "type" for tests-server and so on tests-xxx. And -f f means "files" for subfeature/tests.

Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done for it, and update the runtests usage print also.

Thanks!

As before runtests could only support tests-client and tests-server,
now it could support tests-guest/tests-gnr/tests-spr and so on test files.

Signed-off-by: Pengfei Xu <[email protected]>
@ysun ysun merged commit f89efd0 into intel:main May 31, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants