Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edac: introduce edac feature into lkvs #229

Closed
wants to merge 1 commit into from
Closed

Conversation

laifryiee
Copy link
Contributor

Intel i10nm EDAC driver supports the Intel 10nm series server integrated memory controller. Introduce this feature into lkvs test suite and add 2 test cases.

BM/edac/README.md Outdated Show resolved Hide resolved
@laifryiee
Copy link
Contributor Author

Thanks for review. Commit is force updated.

@ysun
Copy link
Contributor

ysun commented May 24, 2024

Hi LaiYi,

One coding style check issue need fix:

Taints found in file: BM/edac/intel_edac.sh
Hints:
BM/edac/intel_edac.sh:38 - Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?., refer to https://github.com/koalaman/shellcheck/wiki/SC2181
Error: Process completed with exit code 1.>>>> Taints found in file: BM/edac/intel_edac.sh
Hints:
BM/edac/intel_edac.sh:38 - Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?., refer to https://github.com/koalaman/shellcheck/wiki/SC2181
Error: Process completed with exit code 1.>>>> Taints found in file: BM/edac/intel_edac.sh
Hints:
BM/edac/intel_edac.sh:38 - Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?., refer to https://github.com/koalaman/shellcheck/wiki/SC2181
Error: Process completed with exit code 1.

Intel i10nm EDAC driver supports the Intel 10nm series server integrated
memory controller. Introduce this feature into lkvs test suite and add 2
test cases.

Signed-off-by: Lai, Yi1 <[email protected]>
@laifryiee
Copy link
Contributor Author

Hi LaiYi,

One coding style check issue need fix:

Taints found in file: BM/edac/intel_edac.sh
Hints:
BM/edac/intel_edac.sh:38 - Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?., refer to https://github.com/koalaman/shellcheck/wiki/SC2181
Error: Process completed with exit code 1.>>>> Taints found in file: BM/edac/intel_edac.sh
Hints:
BM/edac/intel_edac.sh:38 - Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?., refer to https://github.com/koalaman/shellcheck/wiki/SC2181
Error: Process completed with exit code 1.>>>> Taints found in file: BM/edac/intel_edac.sh
Hints:
BM/edac/intel_edac.sh:38 - Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?., refer to https://github.com/koalaman/shellcheck/wiki/SC2181
Error: Process completed with exit code 1.

Modified accoring to reference coding style.

@laifryiee laifryiee closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants