Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 4 intel_sdsi current_meter cases #228

Merged
merged 3 commits into from
May 27, 2024
Merged

Conversation

qwang59
Copy link
Contributor

@qwang59 qwang59 commented May 22, 2024

No description provided.

@@ -1,5 +1,8 @@
# This file collects basic cases which can run against sdsi driver
# on Intel® Architecture-based server platforms.
# @hw_dep: general_test.sh -t fms -p "sdsi_fms_list" @ CPU Model doesn't support sdsi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @qwang59 , I don't think this is correct to call the script general_test.sh. The parameter '-p' likely can not accept a file. Could you please check it out? Or I missed something about it..

Copy link
Contributor

@xupengfe xupengfe May 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ysun and @qwang59 ,
Parameter '-p' could accept a file, just this file has executable right. We don't really use the list file to execute and just detect the list file.
It could work as expected if sdsi_fms_list file has executable right.

Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get it. Thanks.

@ysun ysun merged commit 4e109a7 into intel:main May 27, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants