Fix ufs #171
Merged
Fix ufs #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sysfs_verify function sets test type as "dir", "file" or "exist" from the parameter, but there is no code that really does the check. The test_print_trc function simply echoes a line no matter the path exists or not. This may cause some false test results such as: $ ls /sys/devices/system/cpu/intel_uncore_frequency/current_freq_khz ls: cannot access '/sys/devices/system/cpu/intel_uncore_frequency/current_freq_khz': No such file or directory $ sudo ./runtests -c "./ufs/tpmi_ufs.sh -t check_ufs_sysfs_attr" <<<test start - './ufs/tpmi_ufs.sh -t check_ufs_sysfs_attr'>> |0122_171944.874|TRACE|Check TPMI_UFS driver sysfs attribute:| |0122_171944.876|TRACE|/sys/devices/system/cpu/intel_uncore_frequency/current_freq_khz does exist| |0122_171944.879|TRACE|/sys/devices/system/cpu/intel_uncore_frequency/initial_max_freq_khz does exist| |0122_171944.881|TRACE|/sys/devices/system/cpu/intel_uncore_frequency/domain_id does exist| |0122_171944.883|TRACE|/sys/devices/system/cpu/intel_uncore_frequency/fabric_cluster_id does exist| |0122_171944.886|TRACE|/sys/devices/system/cpu/intel_uncore_frequency/initial_min_freq_khz does exist| |0122_171944.888|TRACE|/sys/devices/system/cpu/intel_uncore_frequency/max_freq_khz does exist| |0122_171944.891|TRACE|/sys/devices/system/cpu/intel_uncore_frequency/min_freq_khz does exist| |0122_171944.893|TRACE|/sys/devices/system/cpu/intel_uncore_frequency/package_id does exist| |0122_171944.899|TRACE|package_00_die_00| <<<test end, result: PASS, duration: 0.057>> Test Start Time: 2024-01-22_17-19-44 -------------------------------------------------------- Testcase Result Exit Value Duration -------- ------ ---------- -------- [RESULT][./ufs/tpmi_ufs.sh -t check_ufs_sysfs_attr] [PASS] [0] [0.057s] -------------------------------------------------------- Reported-by: kernel test robot <[email protected]> Signed-off-by: Yujie Liu <[email protected]>
…t exist If the kernel is built without CONFIG_INTEL_UNCORE_FREQ_CONTROL enabled, the driver sysfs path won't exist, so the tests are expected to fail, but actually it gives PASS results: <<<test start - 'tpmi_ufs.sh -t check_ufs_init_min_max_value'>> ls: cannot access '/sys/devices/system/cpu/intel_uncore_frequency': No such file or directory |1214_133318.071|TRACE|Uncore number: 0| <<<test end, result: PASS, duration: 0.032>> <<<test start - 'tpmi_ufs.sh -t check_ufs_min_equals_to_max'>> ls: cannot access '/sys/devices/system/cpu/intel_uncore_frequency': No such file or directory <<<test end, result: PASS, duration: 0.030>> <<<test start - 'tpmi_ufs.sh -t check_ufs_max_equals_to_min'>> ls: cannot access '/sys/devices/system/cpu/intel_uncore_frequency': No such file or directory <<<test end, result: PASS, duration: 0.031>> <<<test start - 'tpmi_ufs.sh -t check_ufs_current_dynamic'>> ls: cannot access '/sys/devices/system/cpu/intel_uncore_frequency': No such file or directory <<<test end, result: PASS, duration: 0.030>> After CONFIG_INTEL_UNCORE_FREQ_CONTROL being enabled in the kernel, if the uncore number is 0, the tests are not done, either, so it is expected to be shown as BLOCK instead of PASS. <<<test start - 'tpmi_ufs.sh -t check_ufs_init_min_max_value'>> |0122_044137.087|TRACE|Uncore number: 0| <<<test end, result: PASS, duration: 0.099>> <<<test start - 'tpmi_ufs.sh -t check_ufs_min_equals_to_max'>> <<<test end, result: PASS, duration: 0.089>> <<<test start - 'tpmi_ufs.sh -t check_ufs_max_equals_to_min'>> <<<test end, result: PASS, duration: 0.091>> <<<test start - 'tpmi_ufs.sh -t check_ufs_current_dynamic'>> <<<test end, result: PASS, duration: 0.099>> Reported-by: kernel test robot <[email protected]> Signed-off-by: Yujie Liu <[email protected]>
|
Thanks Yujie for your patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @qwang59, we noticed some possible problems when running the ufs tests in 0-Day CI. Not sure if we did the correct fix. Could you please help review? Thanks.