Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guest test td func 1213 #154

Merged
merged 4 commits into from
Dec 21, 2023
Merged

Guest test td func 1213 #154

merged 4 commits into from
Dec 21, 2023

Conversation

hongyuni
Copy link
Contributor

No description provided.

improve on test_launcher timeout logic control on test_executor:
- extend TIMEOUT from 300 to 900 to adapt to new TDX guest TCs
- add return code in guest_test_close function
- check guest_test_close return code for all TCs

[Test Components] tdx
[Test Types] func
[Supported Devices] spr,emr,gnr,srf

Signed-off-by: Hongyu Ning <[email protected]>
add 3 lazy accept memory functional TCs base on guest-test framework

[Test Components] tdx
[Test Types] func
[Supported Devices] spr,emr,gnr,srf

Signed-off-by: Hongyu Ning <[email protected]>
@hongyuni hongyuni force-pushed the guest_test_td_func_1213 branch from a76e85e to ff3b081 Compare December 13, 2023 09:22
add TDX #VE HALT handling TC based on tdx_halt_test_module

[Test Components] tdx
[Test Types] func
[Supported Devices] spr,emr,gnr,srf

Signed-off-by: Hongyu Ning <[email protected]>
@hongyuni hongyuni force-pushed the guest_test_td_func_1213 branch from ff3b081 to 205ecaf Compare December 14, 2023 01:24
return 0
else
return 1
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent missing here ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, my bad (miss-leading by the EOF line before), revised all such issues in this source code.

###################### Do Works ######################
if [[ -f "$test_module".ko ]]; then
test_print_trc "Kernel test module: $test_module.ko is ready for test"
insmod "$test_module".ko || \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Hongyu, it seems that you haven't created the module. I guess it needs to be compiled before inserting it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a test module (the following: guest-test/tdx/tdx_halt_test_module/halt_test.c) being compiled before above test script execution

pr_info("[TD guest test] Start to trigger hlt instr.\n");
asm("cli");
asm("hlt");
return 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worthwhile to create a separate kernel module for this?
I have an idea about creating a common test module in LKVS.
Let's have a discussion later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that would be nice, let's discuss your common test module solution

@ysun ysun merged commit 6ad9072 into intel:main Dec 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants